Fix: Display abbreviated addresses consistently

[nicosampler]

Closes #1144.

[mmv08]

Could you please include a meaningful PR name instead of issue number?

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	1	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1174--safereact.review.gnosisdev.com/app

[lukasschor]

alignment is a bit off

[lukasschor]

Is it intentional that this PR does not yet cover these addresses? (Would be fine for me, but then we should just create a follow-on ticket)

[lukasschor]

Same for these addresses in the creation transaction. Here I'm even more in favor of adding it later if it takes more than a couple of minutes change. :)

[lukasschor]

Not so sure about the on-click outline. I like that there is more feedback that the address was copied to clipboard, but:

1. the outline is a bit off (more space below)
2. I think the outline should eventually still go away (e.g. after 2-3 seconds).

[lukasschor]

Also slight alignment issues here. If that should be somehow complicated to fix for some reason, I'm also happy to deactivate my OCD here. :P

[mmv08]

I think the outline should eventually still go away (e.g. after 2-3 seconds).

unfortunately that's how browsers work, it will go away if you click somewhere else
Also fyi why this is needed: http://www.outlinenone.com/

[ghost]

Travis automatic deployment:
https://pr1174--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1174--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1174--safereact.review.gnosisdev.com/app

[francovenica]

EDIT: this issue is in DEV as well, and it just with that safe address. Still I need that safe and it could be in others safe we gotta fix it. I'll create a separated issue

@nicosampler
I cannot load safes in this PR. I get this error in the console
This is the safe I'm trying to load: 0x9913B9180C20C6b0F21B6480c84422F6ebc4B808
I tried in Chrome and Brave

[lukasschor]

Product-wise it looks good!

[lukasschor]

For some reason all tx hashes lead to an invalid address page on etherscan. Such as this one: https://rinkeby.etherscan.io/address/0xb052804c5a723c5cfc33a754099209aa119408f7a2a96c4df6bd75dda561a866

[nicosampler]

Good catch @lukasschor. I pushed the fix, but it won't work in the review app until this PR 5afe/safe-react-components#50 is merged.

[nicosampler]

CC: @mikheevm

[mmv08]

@francovenica @lukasschor I think it's important to show the full address at least somewhere. I've seen a post where the user mistyped one symbol of an address and transferred 10000$ to the wrong address

[lukasschor]

@francovenica @lukasschor I think it's important to show the full address at least somewhere. I've seen a post where the user mistyped one symbol of an address and transferred 10000$ to the wrong address

Sure, this ticket is not about abbreviating all addresses, just about formatting the already abbreviated ones differently / consistently. Maybe at some point we could abbreviate them all and only show full address on hover.

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[nicosampler]

@francovenica ready to test.
@lukasschor I fixed the problem with Etherscan links.

[ghost]

Travis automatic deployment:
https://pr1174--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1174--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1174--safereact.review.gnosisdev.com/app

[dasanra]

This PR looks good to me and issues commented are solved.

This should be ready to merge to development