Runtime error: `currentSession` reducer fails to update viewed safe

[fernandomg]

UPDATE_VIEWED_SAFE is not expecting the state to be undefined.

The initialization of the store is triggered in https://github.com/gnosis/safe-react/blob/development/src/index.tsx#L17

This causes, some times, a race condition where viewedSafe is not set, and UPDATE_VIEWED_SAFE is called.

The attempted solution in #1316 (comment) is not good.

I think we should revisit the store initialization flow. Is it ok to have those dispatches in src/index.tsx anyway?

[fernandomg]

891edd3

This issue should be tackled in this issue resolution, as it's another race-condition type error

[mmv08]

Is it ok to have those dispatches in src/index.tsx anyway?

What are the other options? We need to do it as early as possible and index.tsx is the entry point for the app

[dasanra]

I was dealing with a similar problem while fixing 1265-strictNullChecks

This should fix it when ready
https://github.com/gnosis/safe-react/pull/1343/files#diff-6569dbb5c73025f3ec557dfb0086c9a4

[dasanra]

This should be already fixed on development

[francovenica]

any way to check this ticket in a functional way?
@fernandomg @dasanra

[mmv08]

@dasanra I also added a "fix" there in case the safe is undefined https://github.com/gnosis/safe-react/pull/1349/files#diff-526cd3ea9b85a85295b8d18f6f25cfa6R106

[dasanra]

This issue is not repeatable anymore after collateral refactor in other ticket.