(Fix) Pending transaction amount set to zero

[fernandomg]

This PR closes #1305, by essentially adding dataDecoded to the mocked transaction.

There were side effects that showed up while developing:

• Pending transactions were no longer displayed as such, for a safe with a threshold > 1 (this should close: Transaction doesn't show pending status when performing an action on an existing tx #1308)
• The mocked transaction missed data to be consistent with the information later provided by the transaction service
• Lastly, there's an open bug for the owner who executed a tx, its pending status is not set: Owner who executes a transaction won't have its status set to 'pending' #1315

Also, there were some runtime errors that complicates the development:

• 212cce6
• 9d350dc
• 891edd3

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	4	0
Ignored	0	N/A

• Result: ✅ success

• Annotations: 4 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/logic/safe/store/actions/processTransaction.ts Line 26 - Object pattern argument should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 26 - Missing return type on function.
• src/logic/safe/store/actions/processTransaction.ts Line 27 - Argument 'dispatch' should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 28 - Argument 'getState' should be typed.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1316--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1316--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1316--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1316--safereact.review.gnosisdev.com/app

[fernandomg]

@mikheevm, @dasanra, @nicosampler, @Agupane can you guys have a look at this PR?

[mmv08]

Good job! Only a few questions about some changes

[ghost]

Travis automatic deployment:
https://pr1316--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1316--safereact.review.gnosisdev.com/app

[fernandomg]

All "runtime fixes" were reverted. And I'll create issues for the different refactors/fixes required.

Thus, this PR remains unchanged

[fernandomg]

@mikheevm can you approve this one to unlock it? I'll wait for @dasanra approval before moving it to Final QA

Thanks!

[francovenica]

Tried sending daiC since that's a token that would show the 0 token being sent bug. That was fixed
Signed with 2 owners without executing right away. The pending status now show up
Same as before, but rejecting the tx
Same as before, but now executing right away. The pending status is back for this scenario as well
Tested 2 tx pending of executing, making sure that the one that is being executed won't jump to the top of the list for no reason. Looks good

Wasn't necessary but I tested by signing with ledger and trezor just in case.

Looks good to me

[ghost]

Travis automatic deployment:
https://pr1316--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1316--safereact.review.gnosisdev.com/app