Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Cannot send NFT if it uses a proxy #1463

@rmeissner

Description

@rmeissner

Details

NFTs that use a proxy (e.g. POAP) cannot be transfered out. This happens because we check if safeTransferFrom is supported by looking at the byte code of the contract, which obviously doesn't work in cases of proxies (therefore we should not do this). If safeTransferFrom is not supported (which is unlikely for NFTs we display as ERC721 requires this method) we fallback to transfer, but transfer is not part of ERC721.

Environment

  • App Version:2.12.1
  • Environment:
    • production (mainnet)

Steps to reproduce

  • Try to send a POAP token

Expected result

  • POAP token gets send

Obtained result

  • Transaction fails

Metadata

Metadata

Assignees

Labels

Bug 🐛Something isn't workingCriticalOnly for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions