Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) - Send erc721 collectible with proxy contact#1508

Merged
Agupane merged 21 commits intodevelopmentfrom
feature/1463-send-nft-proxt
Oct 26, 2020
Merged

(Feature) - Send erc721 collectible with proxy contact#1508
Agupane merged 21 commits intodevelopmentfrom
feature/1463-send-nft-proxt

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Oct 20, 2020 •
edited
Loading

Closes #1463

Note

  • Also typed several files that I found that weren't

@Agupane
Removed containsMethodByHash condition check, now we always expect th…
bf07a3a 
…at safeTransferFrom is defined on the erc721 contract
@Agupane Agupane self-assigned this Oct 20, 2020
@github-actions
Copy link

github-actions bot commented Oct 20, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 20, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 20, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 20, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 20, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@Agupane Agupane requested a review from fernandomg October 21, 2020 12:50
fernandomg
fernandomg reviewed Oct 22, 2020
View reviewed changes
@Agupane Agupane requested a review from fernandomg October 22, 2020 15:26
@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

dasanra
dasanra suggested changes Oct 23, 2020
View reviewed changes
@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@Agupane Agupane requested review from dasanra and fernandomg October 23, 2020 15:39
@Agupane
Merge branch 'development' of https://github.com/gnosis/safe-react in…
27faf79 
…to feature/1463-send-nft-proxt

# Conflicts:
#	src/routes/safe/components/Balances/SendModal/screens/ReviewCollectible/index.tsx
@Agupane
Fix import
d659595
@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 26, 2020

Travis automatic deployment:
https://pr1508--safereact.review.gnosisdev.com/app

@Agupane Agupane merged commit 058fec3 into development Oct 26, 2020
@Agupane Agupane deleted the feature/1463-send-nft-proxt branch October 26, 2020 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@francovenica francovenica Awaiting requested review from francovenica

2 more reviewers

@fernandomg fernandomg fernandomg approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Agupane Agupane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot send NFT if it uses a proxy

3 participants

@Agupane @fernandomg @dasanra