Contract interation + tx builder: ETH field doesn't appear for payable function

[tschubotz]

Title/Description

Contract interation: ETH field doesn't appear for payable function

Environment

• Browser: firefox
• Safe: any
• Wallet: MM
• App Version: 2.16.0
• Environment:
  • production (mainnet)

Steps to reproduce

1. "new transaction"
2. "contract interaction"
3. Enter ABI:

[{"inputs":[],"stateMutability":"nonpayable","type":"constructor"},{"anonymous":false,"inputs":[{"indexed":false,"internalType":"bytes","name":"pubkey","type":"bytes"},{"indexed":false,"internalType":"bytes","name":"withdrawal_credentials","type":"bytes"},{"indexed":false,"internalType":"bytes","name":"amount","type":"bytes"},{"indexed":false,"internalType":"bytes","name":"signature","type":"bytes"},{"indexed":false,"internalType":"bytes","name":"index","type":"bytes"}],"name":"DepositEvent","type":"event"},{"inputs":[{"internalType":"bytes","name":"pubkey","type":"bytes"},{"internalType":"bytes","name":"withdrawal_credentials","type":"bytes"},{"internalType":"bytes","name":"signature","type":"bytes"},{"internalType":"bytes32","name":"deposit_data_root","type":"bytes32"}],"name":"deposit","outputs":[],"stateMutability":"payable","type":"function"},{"inputs":[],"name":"get_deposit_count","outputs":[{"internalType":"bytes","name":"","type":"bytes"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"get_deposit_root","outputs":[{"internalType":"bytes32","name":"","type":"bytes32"}],"stateMutability":"view","type":"function"},{"inputs":[{"internalType":"bytes4","name":"interfaceId","type":"bytes4"}],"name":"supportsInterface","outputs":[{"internalType":"bool","name":"","type":"bool"}],"stateMutability":"pure","type":"function"}]

4. Select "deposit" function

Expected result

There is a field to enter ETH since deposit is payable

Obtained result

No field to enter ETH.
(When entering other fields, clickling "review" and going back, the field appears.

Screenshots

Misc

• This also affects the tx builder.
• Reason seems to be that we only check for payable:true, however that was changed with solidity 0.6.
• I thought we fixed this in Transaction builder can't load the ABI for Uniswap safe-global/safe-react-apps#29

[tschubotz]

Same issue exists for the tx builder.

Seems like the reason is that the deposit function is payable in the solidity code but doesn't have the payable:true modifier in the ABI.