Show ETH value input for payable methods (fix for solidity v0.6x)#84
Merged
dasanra merged 2 commits intodevelopmentfrom Dec 14, 2020
Merged
Show ETH value input for payable methods (fix for solidity v0.6x)#84dasanra merged 2 commits intodevelopmentfrom
dasanra merged 2 commits intodevelopmentfrom
Conversation
dasanra
reviewed
Dec 11, 2020
| const isValueInputVisible = () => getContractMethod()?.payable; | ||
| const isValueInputVisible = () => { | ||
| const method = getContractMethod(); | ||
| debugger |
Contributor
There was a problem hiding this comment.
I think this is a leftover
dasanra
approved these changes
Dec 11, 2020
Contributor
|
This app can be tested here https://ipfs.io/ipfs/QmYES1Se6i6679z3PfQ62bydgVVEoSRUabvjB35DfUGPGA/ |
|
Tested this in the 5afe/safe-react#1717, using the URL given in Dani's comment It looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially Closes 5afe/safe-react#1680