Safe in read-only mode even though correct owner is connected

[lukasschor]

Title/Description

We've recently had multiple users report that they are confused about seeing a "Read only" mode label. Initially I thought it was just users connecting the wrong wallets to the app. But now I have experienced the same issue.

When opening a Safe via URL in a new browser tab and blocknative automatically connects to my Metamask account that is set on the correct owner, I still end up in read-only mode.

Also a few other issues appear:

• Settings shows 0 owners
• Safe name changes to LOADED SAFE
• Threshold in settings shows "2 out of 0"

Maybe this is related to the onboard.js implementation.

Environment

• Browser: Chrome
• App Version: 2.16.0.
• Environment:
  • production (mainnet)
• Wallet: Metamask

Steps

1. Open Safe in one tab (-> Settings, owners etc are loaded correctly.)
2. Open the same safe via direct link in another tab

Expected

• Usual Safe name
• Safe is not read only.

Observed

• Safe name changes to LOADED SAFE
• Safe is read only
• 0 owners is displayed in settings

Updates

• Dec 3, Tobi: Added steps and more details.

[Agupane]

The cause of this bug seems to be a race condition between useLoadSafe and useSafeScheduledUpdates

Seems that in some place of the code we are fetching the owners ok:

  const [[, remoteThreshold, remoteNonce, remoteOwners = []], safeInfo, localSafe] = await Promise.all([
    generateBatchRequests<[undefined, string | undefined, string | undefined, string[]]>({
      abi: GnosisSafeSol.abi as AbiItem[],
      address: safeAddress,
      methods: safeParams,
    }),
    getSafeInfo(safeAddress),
    getLocalSafe(safeAddress),
  ])

but then we are assigning [] to the owners list, I think the empty is coming from the localStorage, but I'm not 100% sure. Will need to do more research

[tschubotz]

@lukasschor just making sure: You don't have a reliable way to reproduce this yet, right? (I did encounter this problem also before, but can't seem to find a way to reproduce this 100%.

[lukasschor]

Yes, for me it's reliably reproducible. I think a requirement is to already have the interface open in one tap and open in one tab and opening it in another one using a deep-link.

[tschubotz]

Yes, for me it's reliably reproducible. I think a requirement is to already have the interface open in one tap and open in one tab and opening it in another one using a deep-link.

That's it! Nice one, I'll add the steps to the ticket. Thanks!

@liliya-soroka that's the key to #1454 as well :)

[fernandomg]

Reopen as there are reported accounts that switch owner's connection status while connected to the safe (without any user interaction). No network or user switch, nor page refresh.

[Agupane]

I'm moving this to "requirements in progress" because I wasn't able to reproduce the issue. It's possible that's already fixed or it just a race condition that is not easy to reproduce. I asked Leandro to let me know in case he founds the bug again
CC: @fernandomg @alfetopito

[tschubotz]

I'm also not able to reproduce this. We had reports of an unstable RPC endpoint. @alfetopito which RPC endpoint are you using? I'm on https://rpc.xdaichain.com/

I would actually close this one as long as it is not reproducible and/or the issue doesn't persist.

fyi @dasanra in case you had ideas on what the issue might be here.