Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) Read only owners on xDai and Volta#1847

Merged
dasanra merged 12 commits intodevelopmentfrom
fix/1685-safe-read-only-volta
Feb 24, 2021
Merged

(Fix) Read only owners on xDai and Volta#1847
dasanra merged 12 commits intodevelopmentfrom
fix/1685-safe-read-only-volta

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Feb 2, 2021

Closes #1685 by:

  • Avoid updating the store when the result of the batch transaction is not defined
  • This error appears only on xDai or Volta, couldn't find a way to reproduce this on Mainnet or Rinkeby

@Agupane Agupane requested review from dasanra and fernandomg February 2, 2021 16:56
@Agupane Agupane self-assigned this Feb 2, 2021
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@Agupane Agupane changed the title Avoid to remove the current loaded safe data if the batch request fail (Fix) Read only owners on xDai and Volta Feb 2, 2021
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Feb 2, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 3, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 3, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 5, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 8, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 9, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 10, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 10, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 11, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@pablofullana pablofullana assigned nicosampler and unassigned Agupane Feb 19, 2021
@nicosampler
Copy link
Contributor

seems to be working fine:
https://www.loom.com/share/11c224840f7c4a0fa44ea1d740fcdb08

@github-actions
Copy link

github-actions bot commented Feb 19, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Feb 19, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Feb 23, 2021

Travis automatic deployment:
https://pr1847--safereact.review.gnosisdev.com/rinkeby/app

@github-actions
Copy link

@dasanra dasanra merged commit ce1ab8b into development Feb 24, 2021
@dasanra dasanra deleted the fix/1685-safe-read-only-volta branch February 24, 2021 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2021
@francovenica
Copy link
Contributor

Looks good to me

Didn't suffer the "only read" mode after being around those environments for some time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safe in read-only mode even though correct owner is connected

5 participants