(Feature) Decode multiSend tx details

[fernandomg]

This PR closes #865, by properly presenting tx's decoded data for multiSend txs in the tx's expanded view.

note: I converted it to draft because, despite it's functional and can be tested, there are pending components refactor required. See 42ed908

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[lukasschor]

I loaded this Safe to see how a Sablier Safe App interaction looks like with decoded Multisend: 0xCfF7eB7C0cAc85188dF7748486A3ab8a20F56315

While doing that, I saw that there is a "Cancellation transaction" being displayed, which is not the case on the production version:

So seems like there is something broken with the tx <> cancellation transaction merging.

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[lukasschor]

Could we make the function & parameter names bold?

Also, Richard had the idea of using the function name in the overview to make it easier to see which Transaction should be expanded to get some information on specific things. So instead of "Transaction 1" it could say "Transaction 1 (approve)". I think this might be an improvement that does not require too much effort, but happy to get your thoughts on this. I'm also fine leaving it out and opening a separate ticket for this.

[francovenica]

Regarding the names of the Tx's. They are shown in the Tx details but not in the app operation itself:
Example: this is a "Supply" in compound, but in the tx details the only thing you can see is the "mint" and "approve" so you don't know that it was a Supply unless you remember it. Also the when you Supply the modal won't show that you are minting and approving

So we could put that this is a "Supply" operation and not just the "mint" and "approve" that is internally done.

This is an example of one app. I still gotta see how it looks on the others

[lukasschor]

Regarding the names of the Tx's. They are shown in the Tx details but not in the app operation itself:
Example: this is a "Supply" in compound, but in the tx details the only thing you can see is the "mint" and "approve" so you don't know that it was a Supply unless you remember it. Also the when you Supply the modal won't show that you are minting and approving

So we could put that this is a "Supply" operation and not just the "mint" and "approve" that is internally done.

This is an example of one app. I still gotta see how it looks on the others

The issue is that the "Supply" name is a human-readable name given by the Safe App. But on the transaction level this information is basically encoded as a approve and mint. We cannot take any information from the Safe app to rely on, as this would create false security to the user and a malicious app could take advantage of this. So the base is the direct transaction data, which we then should aim to decode as much as possible over time to show to the user the consequences of the transaction in a human-readable manner.

And yes, we will also display the decoded Data in the Safe Apps modal, but this is not part of this PR.

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	2	0
Ignored	3	N/A

• Result: ✅ success

• Annotations: 2 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/logic/addressBook/store/reducer/addressBook.ts Line 20 - Missing return type on function.
• src/logic/addressBook/store/reducer/addressBook.ts Line 20 - Argument 'storedAdbk' should be typed.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[francovenica]

I repeated the same test I did the last time, trying every app possible in rinkeby and checking that they look fine in the tx and its details

The safe: https://pr1106--safereact.review.gnosisdev.com/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/transactions

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app

[fernandomg]

@mikheevm, please, don't forget to review recent changes

[mmv08]

return type is a little bit off here, it can also return typeof notSetValue

[francovenica]

Tried one more time in a new safe and incognito mode and it worked fine
I've tried Compound, Sablier, Idle and The Tx builder (replicating a compound contract method).

Looks good to me

Safe for testing: https://pr1106--safereact.review.gnosisdev.com/app/#/safes/0x5D0edD9272a653Bf6b3b49e9856c7030942d2003/transactions

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[ghost]

Travis automatic deployment:
https://pr1106--safereact.review.gnosisdev.com/app