This repository was archived by the owner on Nov 10, 2023. It is now read-only.
fix: show tx data for txs with decoded params#1113
Closed
troggy wants to merge 1 commit into5afe:developmentfrom
Closed
fix: show tx data for txs with decoded params#1113troggy wants to merge 1 commit into5afe:developmentfrom
troggy wants to merge 1 commit into5afe:developmentfrom
Conversation
Contributor
|
Thanks! @fernandomg is planning to include this fix as part of this PR: #1106 |
Author
|
We are using a fork with the fix anyway, so it is fine to wait for the upstream fix |
Contributor
|
Will be covered by #1106. Thanks for the report! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no tx data shown for transactions with
decodedParamsand thus such txs are impossible to verify before signing.For instance, this is how the
ERC20.approvefunction call looks like in our Safe:This PR suggests a quick fix to show raw hex data for such transactions.
NB: I have a code which displays decoded params as well, but I've noticed you have some work already going in this direction — let me know if it still worth a PR.