(Feature) Balances enhancements by Agupane · Pull Request #1122 · 5afe/safe-react

Agupane · 2020-07-17T14:46:10Z

Closes #408
Also closes #444

Add type return on fetchCurrencyValues

Adds support for ETH as currency

Uses formatAmountInUsFormat for BALANCE_TABLE_BALANCE_ID

Add tests

src/config/index.ts

…to balances-enhacements # Conflicts: # src/routes/safe/components/Balances/dataFetcher.ts # src/store/index.ts

src/logic/currencyValues/api/fetchCurrenciesRates.ts

…ces-enhacements

ghost · 2020-07-23T13:27:03Z

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

ghost · 2020-07-23T13:29:41Z

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

francovenica · 2020-07-23T19:02:43Z

@Agupane This PR is not loading for me

…ces-enhacements

ghost · 2020-07-24T14:49:54Z

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

francovenica · 2020-07-24T18:28:22Z

The PR works now

The font of the total was fixed. It changes when you change the type of currency you want in the dropdown.
The Eth round is better, idk if something was done about it. Tried send some eth to try different values to check the round and it looks good

Agupane · 2020-07-28T12:39:45Z

Hey @mikheevm could you give this a look?

ghost · 2020-07-28T12:58:55Z

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

src/logic/currencyValues/api/fetchTokenCurrenciesBalances.ts

src/test/logic/token/utils/formatAmount.test.ts

src/routes/safe/components/Layout/Header/index.tsx

src/routes/safe/components/Balances/dataFetcher.ts

src/logic/tokens/utils/formatAmount.ts

…ces-enhacements

ghost · 2020-07-28T13:30:19Z

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

ghost · 2020-07-28T13:32:29Z

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

src/logic/tokens/utils/formatAmount.ts

ghost · 2020-07-28T15:28:50Z

Travis automatic deployment:
https://pr1122--safereact.review.gnosisdev.com/app

Agupane added 12 commits July 16, 2020 10:55

Fix ts error

5602812

Add type return on fetchCurrencyValues

Add skeleton for loading balance value

ac742d8

Fix texts in uppercase

0c7c5aa

Adds ETH Icon in currencyValues dropdown

2b8056e

Adds getExchangeRatesUrlFallback

e7693d2

Adds support for ETH as currency

Alphabetically sort currencies

762861d

Add types

a12b62a

Type formatAmount

672d8f4

Adds formatAmountInUsFormat util function

fc866db

Add types

4676074

Uses formatAmountInUsFormat for BALANCE_TABLE_BALANCE_ID

Updates max and min fraction digits on formatAmountInUsFormat

3c5e37a

Add tests

Updates max and min fraction digits on formatAmountInUsFormat

5aac964

Add tests

Agupane added the WIP label Jul 17, 2020

Agupane self-assigned this Jul 17, 2020

lukasschor reviewed Jul 17, 2020

View reviewed changes

src/config/index.ts Show resolved Hide resolved

Agupane added 13 commits July 18, 2020 11:40

Add types

4648ac0

Fix currencyValues types

188f8fb

Adds safeFiatBalancesTotalSelector

f4ae546

Adds total balance to safe header

2ec2a6b

Merge branch 'development' of https://github.com/gnosis/safe-react in…

b490b16

…to balances-enhacements # Conflicts: # src/routes/safe/components/Balances/dataFetcher.ts # src/store/index.ts

Fix types

91eb070

Adds currentCurrency on header

931d0ce

Adds types to getTokenPriceInCurrency

31f1ce0

Fix balance currency rate conversion

58168eb

Add guards for modules

0318452

Merge branch 'fix-add-type-guards' into balances-enhacements

dc44932

Add guards for modules

f32e606

Merge branch 'fix-add-type-guards' into balances-enhacements

039ae42

Agupane mentioned this pull request Jul 20, 2020

new TXs tab #1089

Merged

5 tasks

Uses console error for api

753ff66

Replaces RecordOf<TokenProps> with Token

00f24e3

fernandomg suggested changes Jul 23, 2020

View reviewed changes

src/logic/currencyValues/api/fetchCurrenciesRates.ts Outdated Show resolved Hide resolved

src/logic/currencyValues/api/fetchCurrenciesRates.ts Outdated Show resolved Hide resolved

Agupane added 2 commits July 23, 2020 10:13

Merge remote-tracking branch 'origin/balances-enhacements' into balan…

be90cf3

…ces-enhacements

Feedback

8625248

francovenica mentioned this pull request Jul 23, 2020

Buttons in Uppercase #444

Closed

Agupane added 3 commits July 24, 2020 11:00

Merge branch 'development' into balances-enhacements

5d3b2ac

Trigger buid

91cd4e4

Merge remote-tracking branch 'origin/balances-enhacements' into balan…

365b5d3

…ces-enhacements

francovenica approved these changes Jul 24, 2020

View reviewed changes

fernandomg approved these changes Jul 24, 2020

View reviewed changes

Agupane removed the request for review from alongoni July 28, 2020 12:39

Merge branch 'development' into balances-enhacements

30bd83f

mmv08 suggested changes Jul 28, 2020

View reviewed changes

Agupane added 3 commits July 28, 2020 10:17

Types

d9b6b6e

Merge remote-tracking branch 'origin/balances-enhacements' into balan…

1ef9d4a

…ces-enhacements

Fix tests order

5391083

mmv08 approved these changes Jul 28, 2020

View reviewed changes

src/logic/tokens/utils/formatAmount.ts Outdated Show resolved Hide resolved

Renames numberFormat to usNumberFormatter

1efec3a

mmv08 merged commit bbfa7d8 into development Jul 28, 2020

mmv08 deleted the balances-enhacements branch July 28, 2020 15:29

Conversation

Agupane commented Jul 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jul 23, 2020

Uh oh!

ghost commented Jul 23, 2020

Uh oh!

francovenica commented Jul 23, 2020

Uh oh!

ghost commented Jul 24, 2020

Uh oh!

francovenica commented Jul 24, 2020

Uh oh!

Agupane commented Jul 28, 2020

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

Uh oh!

ghost commented Jul 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Agupane commented Jul 17, 2020 •

edited

Loading