1265 Restore strict null checks

[dasanra]

Add strict null checks changes to development

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	70	0
Ignored	8	N/A

• Result: ✅ success

• Annotations: 70 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/components/App/ReceiveModal.tsx Line 82 - Missing return type on function.
• src/components/Table/TableHead.tsx Line 22 - Argument 'property' should be typed.
• src/components/Table/TableHead.tsx Line 22 - Argument 'orderAttr' should be typed.
• src/components/Table/TableHead.tsx Line 22 - Missing return type on function.
• src/components/Table/TableHead.tsx Line 28 - Missing return type on function.
• src/logic/currencyValues/store/middleware/index.ts Line 6 - Argument 'store' should be typed.
• src/logic/currencyValues/store/middleware/index.ts Line 6 - Argument 'next' should be typed.
• src/logic/currencyValues/store/middleware/index.ts Line 6 - Missing return type on function.
• src/logic/currencyValues/store/middleware/index.ts Line 6 - Argument 'action' should be typed.
• src/logic/currentSession/utils/index.ts Line 9 - Missing return type on function.
• src/logic/currentSession/utils/index.ts Line 9 - Argument 'currentSession' should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 26 - Object pattern argument should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 26 - Missing return type on function.
• src/logic/safe/store/actions/processTransaction.ts Line 27 - Argument 'dispatch' should be typed.
• src/logic/safe/store/actions/processTransaction.ts Line 28 - Argument 'getState' should be typed.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'store' should be typed.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'next' should be typed.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Missing return type on function.
• src/logic/safe/store/middleware/notificationsMiddleware.ts Line 70 - Argument 'action' should be typed.
• src/logic/safe/transactions/awaitingTransactions.ts Line 8 - Argument 'cancellationTxs' should be typed.
• src/logic/safe/transactions/offchainSigner/ethSigner.ts Line 7 - Object pattern argument should be typed.
• src/logic/safe/utils/safeStorage.ts Line 25 - Missing return type on function.
• src/logic/safe/utils/safeStorage.ts Line 25 - Argument 'safes' should be typed.
• src/logic/tokens/store/actions/fetchTokens.ts Line 46 - Missing return type on function.
• src/logic/tokens/store/actions/fetchTokens.ts Line 46 - Argument 'contractAddress' should be typed.
• src/logic/tokens/store/actions/fetchTokens.ts Line 46 - Argument 'methodHash' should be typed.
• src/logic/tokens/store/actions/fetchTokens.ts Line 90 - Missing return type on function.
• src/logic/tokens/store/actions/fetchTokens.ts Line 90 - Argument 'dispatch' should be typed.
• src/logic/tokens/store/actions/fetchTokens.ts Line 90 - Argument 'getState' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'store' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'next' should be typed.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Missing return type on function.
• src/logic/wallets/store/middlewares/providerWatcher.ts Line 20 - Argument 'action' should be typed.
• src/routes/load/components/DetailsForm/index.tsx Line 51 - Argument 'values' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Object pattern argument should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 159 - Argument 'network' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 160 - Argument 'controls' should be typed.
• src/routes/load/components/OwnerList/index.tsx Line 160 - Object pattern argument should be typed.
• src/routes/open/components/SafeNameForm/index.tsx Line 74 - Argument 'controls' should be typed.
• src/routes/open/components/SafeNameForm/index.tsx Line 74 - Object pattern argument should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 46 - Missing return type on function.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 46 - Argument 'index' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 46 - Argument 'notRemovedOwners' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 46 - Argument 'values' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 229 - Object pattern argument should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 230 - Missing return type on function.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 230 - Argument 'controls' should be typed.
• src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 230 - Object pattern argument should be typed.
• src/routes/open/container/Open.tsx Line 48 - Missing return type on function.
• src/routes/open/container/Open.tsx Line 48 - Argument 'safeAddress' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'safeName' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'ownersNames' should be typed.
• src/routes/open/container/Open.tsx Line 48 - Argument 'ownerAddresses' should be typed.
• src/routes/open/container/Open.tsx Line 56 - Missing return type on function.
• src/routes/open/container/Open.tsx Line 56 - Argument 'values' should be typed.
• src/routes/open/container/Open.tsx Line 56 - Argument 'userAccount' should be typed.
• src/routes/opening/index.tsx Line 105 - Missing return type on function.
• src/routes/opening/index.tsx Line 105 - Object pattern argument should be typed with a non-any type.
• src/routes/safe/components/Balances/SendModal/SafeInfo/index.tsx Line 7 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/ChooseTxType/index.tsx Line 63 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/ChooseTxType/index.tsx Line 63 - Object pattern argument should be typed.
• src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Missing return type on function.
• src/routes/safe/components/Balances/SendModal/screens/SendCollectible/index.tsx Line 46 - Object pattern argument should be typed.
• src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/ThresholdForm/index.tsx Line 26 - Missing return type on function.
• src/routes/safe/components/Settings/ManageOwners/RemoveOwnerModal/screens/ThresholdForm/index.tsx Line 26 - Object pattern argument should be typed.
• src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Missing return type on function.
• src/routes/safe/components/Settings/RemoveSafeModal/index.tsx Line 32 - Object pattern argument should be typed.
• src/utils/intercom.ts Line 4 - Missing return type on function.

---

[warning] @typescript-eslint/no-non-null-assertion

Disallows non-null assertions using the ! postfix operator

• src/routes/safe/components/Transactions/TxsTable/TxType/index.tsx Line 74 - Forbidden non-null assertion.
• src/routes/safe/components/Transactions/TxsTable/TxType/index.tsx Line 74 - Forbidden non-null assertion.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1336--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1336--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1336--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1336--safereact.review.gnosisdev.com/app

[mmv08]

@dasanra unfortunately there are ts errors after pulling from dev, could you please take a look?

[dasanra]

@mikheevm Was just checking them, was surprised when my changes were rejected !

[ghost]

Travis automatic deployment:
https://pr1336--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1336--safereact.review.gnosisdev.com/app