Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Bugfix) - #1286 Fix Sidebar position#1340

Merged
mmv08 merged 5 commits intodevelopmentfrom
issue-1286
Sep 14, 2020
Merged

(Bugfix) - #1286 Fix Sidebar position#1340
mmv08 merged 5 commits intodevelopmentfrom
issue-1286

Conversation

@alongoni
Copy link
Contributor

@alongoni alongoni commented Sep 10, 2020 •
edited
Loading

Related to #1286
Sidebar is 100% height now. Help Center button is visible and don't scroll down
https://www.loom.com/share/6f9ee3c6f4c14466abbf0a0244a13ffa

@github-actions
Copy link

github-actions bot commented Sep 10, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 10, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 10, 2020

Travis automatic deployment:
https://pr1340--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 10, 2020

Travis automatic deployment:
https://pr1340--safereact.review.gnosisdev.com/app

@alongoni alongoni added Enhancement ✨ Minor Improvement / changes to existing functionality Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. and removed Enhancement ✨ Minor Improvement / changes to existing functionality labels Sep 10, 2020
@nicosampler
Copy link
Contributor

nicosampler commented Sep 11, 2020

@alongoni did you tried to add more items in the sidebar-list to see how it behaves?

@lukasschor lukasschor changed the title fix Sidebar position (Bugfix) - #1286 Fix Sidebar position Sep 11, 2020
@alongoni
Copy link
Contributor Author

alongoni commented Sep 11, 2020 •
edited
Loading

We have scroll now!
https://www.loom.com/share/92f21adcb1fb433ab0313083f4775247

@ghost
Copy link

ghost commented Sep 11, 2020

Travis automatic deployment:
https://pr1340--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 11, 2020

Travis automatic deployment:
https://pr1340--safereact.review.gnosisdev.com/app

@lukasschor lukasschor self-requested a review September 14, 2020 08:23
lukasschor
lukasschor approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@lukasschor lukasschor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mmv08 mmv08 merged commit 5b99cea into development Sep 14, 2020
@mmv08 mmv08 deleted the issue-1286 branch September 14, 2020 11:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fernandomg fernandomg Awaiting requested review from fernandomg

@nicosampler nicosampler Awaiting requested review from nicosampler

2 more reviewers

@lukasschor lukasschor lukasschor approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alongoni @nicosampler @lukasschor @dasanra @mmv08