Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Chore) Type fixes and refactor#1376

Merged
dasanra merged 8 commits intodevelopmentfrom
chore/type-fixes
Sep 22, 2020
Merged

(Chore) Type fixes and refactor#1376
dasanra merged 8 commits intodevelopmentfrom
chore/type-fixes

Conversation

@fernandomg
Copy link
Contributor

While debugging for #1375 found some snippets of code that require types. Also, did a slight refactor in a couple of files.

This shouldn't affect the functionality, just the code.

@fernandomg fernandomg self-assigned this Sep 18, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 18, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 18, 2020

Travis automatic deployment:
https://pr1376--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 21, 2020

Travis automatic deployment:
https://pr1376--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 22, 2020

Travis automatic deployment:
https://pr1376--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 22, 2020

Travis automatic deployment:
https://pr1376--safereact.review.gnosisdev.com/app

@dasanra dasanra merged commit eec6e64 into development Sep 22, 2020
@dasanra dasanra deleted the chore/type-fixes branch September 22, 2020 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2020
@dasanra
Copy link
Collaborator

dasanra commented Sep 22, 2020

This were only some code refactor and styles improvement. No QA is required

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants