(Fix) (development) Missing collectibles and Safe version#1375
(Fix) (development) Missing collectibles and Safe version#1375dasanra merged 11 commits intodevelopmentfrom
Conversation
fernandomg
requested review from
Agupane,
dasanra,
matextrem and
nicosampler
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
src/logic/safe/store/reducer/safe.ts
Outdated
| makeSafe({ name: 'LOADED SAFE', address: safeAddress }), | ||
| (prevSafe) => prevSafe.merge(safe), | ||
| // `mergeDeep` because with `merge` nested data gets overwritten | ||
| (prevSafe) => prevSafe.mergeDeep(safe), |
There was a problem hiding this comment.
Adding this mergeDeep activates the owner list multiply bug. You can check it going to settings/owners and try to full reload the app.
Also visible in transaction list when expanding details
There was a problem hiding this comment.
Dani, I may have a working solution but ended up solving it using a sleep, just for testing purposes. I guess that with a piece of context information (a flag) I will have it properly working.
Will upload the changes tomorrow.
There was a problem hiding this comment.
@dasanra, well I ended up with the not so elegant solution.
I'll later create a draft PR with the current status my work on fixing the loading process. I need to make a final review of my notes.
BTW, I think it's about time to start thinking about adding XState, as Nico suggested. This is a really good scenario to start with it. Thoughts?
- treat every key individually
|
Travis automatic deployment: |
|
Travis automatic deployment: |
* fix address being used as name * Restore ENS name when sending transaction * use `addressName` as default value if it happens that the name in the addressBook is not defined * use resolvedAddress to filter by address in the address book Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm> Co-authored-by: Mati Dastugue <matias.dastugue@altoros.com>
* use `safeFeaturesEnabled` selector also organized a bit the code (styles) and added Types for the `ChooseTxType` component * fix `getGnosisSafeInstanceAt` return type * add types to `safeStorage` refactor `getSafeName` * use redux selector to obtain master contract version * fix return type Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
|
Travis automatic deployment: |
1 similar comment
|
Travis automatic deployment: |
|
Found that by loading a Safe with the URL, Owners take a while to appear in the Settings tab (~15s). This is because owners won't be loaded to the redux if there's no Safe information stored in the The fix is in the commit |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
1 similar comment
|
Travis automatic deployment: |
3 participants
This PR fixes an error in the current
developmentbranch where NFTs got missing and the safe's version was not set.