Filter Apps by network#1433
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
nicosampler
requested review from
Agupane,
dasanra,
fernandomg,
matextrem and
mmv08
|
Travis automatic deployment: |
fernandomg
left a comment
fernandomg
left a comment
There was a problem hiding this comment.
xDai network is missing.
The rest looks good, although, I found it a bit hard to reason about it and follow. But the core logic was already there, so it's nothing that should be addressed here anyway.
| // OpenZeppelin | ||
| { url: `${process.env.REACT_APP_IPFS_GATEWAY}/QmQovvfYYMUXjZfNbysQDUEXR8nr55iJRwcYgJQGJR7KEA`, disabled: false }, | ||
| { | ||
| url: `${process.env.REACT_APP_IPFS_GATEWAY}/QmQovvfYYMUXjZfNbysQDUEXR8nr55iJRwcYgJQGJR7KEA`, | ||
| disabled: false, | ||
| networks: [ | ||
| ETHEREUM_NETWORK.MAINNET, | ||
| ETHEREUM_NETWORK.RINKEBY, | ||
| ETHEREUM_NETWORK.ENERGY_WEB_CHAIN, | ||
| ETHEREUM_NETWORK.VOLTA, | ||
| ], | ||
| }, | ||
| // TX-Builder | ||
| { url: `${gnosisAppsUrl}/tx-builder`, disabled: false }, | ||
| { | ||
| url: `${gnosisAppsUrl}/tx-builder`, | ||
| disabled: false, | ||
| networks: [ | ||
| ETHEREUM_NETWORK.MAINNET, | ||
| ETHEREUM_NETWORK.RINKEBY, | ||
| ETHEREUM_NETWORK.ENERGY_WEB_CHAIN, | ||
| ETHEREUM_NETWORK.VOLTA, | ||
| ], | ||
| }, | ||
| // Wallet-Connect | ||
| { url: `${gnosisAppsUrl}/walletConnect`, disabled: false }, | ||
| { | ||
| url: `${gnosisAppsUrl}/walletConnect`, | ||
| disabled: false, | ||
| networks: [ | ||
| ETHEREUM_NETWORK.MAINNET, | ||
| ETHEREUM_NETWORK.RINKEBY, | ||
| ETHEREUM_NETWORK.ENERGY_WEB_CHAIN, | ||
| ETHEREUM_NETWORK.VOLTA, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
ETHEREUM_NETWORK.XDAI is missing in those
There was a problem hiding this comment.
🤦♂️ Good catch! added.
|
Travis automatic deployment: |
|
Travis automatic deployment: |
3 participants
closes #1361.