Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

RPC interactions errors#1475

Merged
dasanra merged 8 commits intofeature/#1353-xDai-compatibilityfrom
issue-1457
Oct 16, 2020
Merged

RPC interactions errors#1475
dasanra merged 8 commits intofeature/#1353-xDai-compatibilityfrom
issue-1457

Conversation

@nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Oct 14, 2020 •
edited by fernandomg
Loading

This issue closes #1457, by properly handling possible errors when RPC calls fails to succeed under generateBatchRequest calls.

@github-actions
Copy link

github-actions bot commented Oct 14, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 14, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 3 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

mmv08
mmv08 reviewed Oct 14, 2020
View reviewed changes
@ghost
Copy link

ghost commented Oct 14, 2020

Travis automatic deployment:
https://pr1475--safereact.review.gnosisdev.com/app

@nicosampler nicosampler self-assigned this Oct 14, 2020
@ghost
Copy link

ghost commented Oct 14, 2020

Travis automatic deployment:
https://pr1475--safereact.review.gnosisdev.com/app

@nicosampler nicosampler marked this pull request as ready for review October 15, 2020 12:37
@dasanra dasanra changed the title RPC interactions erros RPC interactions errors Oct 16, 2020
@ghost
Copy link

ghost commented Oct 16, 2020

Travis automatic deployment:
https://pr1475--safereact.review.gnosisdev.com/app

@dasanra dasanra merged commit 53a341c into feature/#1353-xDai-compatibility Oct 16, 2020
@dasanra dasanra deleted the issue-1457 branch October 16, 2020 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmv08 mmv08 Awaiting requested review from mmv08

@Agupane Agupane Awaiting requested review from Agupane

@matextrem matextrem Awaiting requested review from matextrem

1 more reviewer

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fernandomg fernandomg

@nicosampler nicosampler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicosampler @mmv08 @dasanra @fernandomg