Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) - #1244 send tx again#1582

Merged
Agupane merged 14 commits intodevelopmentfrom
feature/#1244-send-tx-again
Nov 11, 2020
Merged

(Feature) - #1244 send tx again#1582
Agupane merged 14 commits intodevelopmentfrom
feature/#1244-send-tx-again

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 9, 2020 •
edited
Loading

Closes #1244 by:

  • Adding the tokenAddresses sent in TransferDescription component
  • Using the SendModal component within TransferDescription
  • Adding a sendModalOpenHandler prop to EllipsisTransactionDetails component

@Agupane Agupane self-assigned this Nov 9, 2020
@github-actions
Copy link

github-actions bot commented Nov 9, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@Agupane Agupane marked this pull request as ready for review November 9, 2020 17:38
@Agupane Agupane requested review from dasanra, fernandomg and francovenica and removed request for dasanra November 9, 2020 17:38
@github-actions
Copy link

github-actions bot commented Nov 9, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 9, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 9, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/volta/app

dasanra
dasanra reviewed Nov 10, 2020
View reviewed changes
@Agupane Agupane requested a review from dasanra November 10, 2020 13:55
@ghost
Copy link

ghost commented Nov 10, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 10, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 10, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 10, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 10, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 10, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/rinkeby/app

@francovenica
Copy link
Contributor

francovenica commented Nov 10, 2020

Tested here: https://pr1582--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x56fEB2573daFf631ae9D610184dF40b0940395Ff/transactions

Make sure is the option is not available for "outgoing tx" for ERC721, modify settings, incoming tx, etc... It works only with "outgoing tx" that send ERC20 tokens.
It copies all the values of the executed tx: address sent to, token, amount.
If the amount is not valid anymore (for lack of funds) the same "Send" modal will fail when trying to submit.

Looks good to me

@dasanra
Copy link
Collaborator

dasanra commented Nov 11, 2020

@Agupane please, check conflicting files and we are ready to merge this

@Agupane
Merge branch 'development' of https://github.com/gnosis/safe-react in…
e1fbcd5 
…to feature/#1244-send-tx-again

# Conflicts:
#	src/routes/safe/components/Balances/SendModal/screens/SendFunds/index.tsx
#	src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/utils.ts
@Agupane
Fix decimals usage in tx transfer amount
c172355
@ghost
Copy link

ghost commented Nov 11, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 11, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 11, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 11, 2020

Travis automatic deployment:
https://pr1582--safereact.review.gnosisdev.com/volta/app

@Agupane Agupane merged commit 294ba47 into development Nov 11, 2020
@Agupane Agupane deleted the feature/#1244-send-tx-again branch November 11, 2020 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fernandomg fernandomg Awaiting requested review from fernandomg

2 more reviewers

@francovenica francovenica francovenica approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Agupane Agupane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Send again" option in tx details not working / not properly placed

3 participants

@Agupane @francovenica @dasanra