(Fix) Duplicated Owner Addresses on Safe Creation#1666
Conversation
- also fixed `calculateValuesAfterRemoving` function that removed an owner's row by clicking on the trash icon
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
This one looks good A new ticket was created for the same issue in Address book and Settings (Adding/replacing owners) |
|
@Agupane, @nicosampler I just added a couple of tests for the 'remove-owner' related function. I was thinking about splitting this into two separate PRs and add tests for the refactored function. But given it's already checked/tested, I did it here 😬 |
|
|
I've never acknowledged that this ticket also fixes 1183. |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
This PR closes #1661, by:
Also fixes #1183, by: