Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) "Send Again" action, missing parameters #1686

Merged
dasanra merged 6 commits intodevelopmentfrom
fix/send-again-not-working
Dec 9, 2020
Merged

(Fix) "Send Again" action, missing parameters #1686
dasanra merged 6 commits intodevelopmentfrom
fix/send-again-not-working

Conversation

@fernandomg
Copy link
Contributor

@fernandomg fernandomg commented Dec 1, 2020

After the merge of the Spending Limit feature, this functionality stopped working.

This PR closes #1664

@fernandomg fernandomg added the Bug 🐛 Something isn't working label Dec 1, 2020
@fernandomg fernandomg self-assigned this Dec 1, 2020
@github-actions
Copy link

github-actions bot commented Dec 1, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@ghost
Copy link

ghost commented Dec 1, 2020

Travis automatic deployment:
https://pr1686--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Dec 1, 2020

Travis automatic deployment:
https://pr1686--safereact.review.gnosisdev.com/rinkeby/app

@github-actions
Copy link

github-actions bot commented Dec 2, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

francovenica commented Dec 2, 2020

Works fine now. The form fill itself with all the data properly

Note: Testing this I've found an issue where the form closes itself for no reason. I reported it separately here #1690 . This issue happens in stg, so this issue is happening before this fix was implemented

@ghost
Copy link

ghost commented Dec 4, 2020

Travis automatic deployment:
https://pr1686--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Dec 9, 2020

Travis automatic deployment:
https://pr1686--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Dec 9, 2020

Travis automatic deployment:
https://pr1686--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Dec 9, 2020

Travis automatic deployment:
https://pr1686--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra merged commit 4079ff9 into development Dec 9, 2020
@dasanra dasanra deleted the fix/send-again-not-working branch December 9, 2020 23:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Send again" feature is not autocompleting the token type and value

5 participants