Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Fix - Send Again modal close on its own#1738

Merged
matextrem merged 16 commits intodevelopmentfrom
fix/modal-close
Dec 22, 2020
Merged

Fix - Send Again modal close on its own#1738
matextrem merged 16 commits intodevelopmentfrom
fix/modal-close

Conversation

@matextrem
Copy link
Contributor

closes #1690

@matextrem matextrem added Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. labels Dec 18, 2020
@matextrem matextrem self-assigned this Dec 18, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 18, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Dec 18, 2020

Travis automatic deployment:
https://pr1738--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Dec 18, 2020

Travis automatic deployment:
https://pr1738--safereact.review.gnosisdev.com/volta/app

Copy link
Contributor

@Agupane Agupane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed my last fix on a local branch and test this fix to be sure that It works and it's working perfectly 🚀

@ghost
Copy link

ghost commented Dec 18, 2020

Travis automatic deployment:
https://pr1738--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Dec 18, 2020

Travis automatic deployment:
https://pr1738--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

It looks good for me.

Note that the ticket #1731 worked on a similar fix for this. Take that in account when merging this ticket.

@francovenica francovenica self-requested a review December 21, 2020 20:46
@matextrem matextrem merged commit 5008ee4 into development Dec 22, 2020
@matextrem matextrem deleted the fix/modal-close branch December 22, 2020 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Send again" form closes on its own

3 participants