Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) - Calculates gas for SpendingLimit transactions#1773

Merged
dasanra merged 5 commits intorelease/v2.18.0from
fix/spending-limit-gas-estimation
Jan 14, 2021
Merged

(Fix) - Calculates gas for SpendingLimit transactions#1773
dasanra merged 5 commits intorelease/v2.18.0from
fix/spending-limit-gas-estimation

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Jan 13, 2021

Description

  • For both spending limits and upgrade safe transactions the estimation was missing inside the modal, this prs adds it
  • Also the gas estimation for sending collectibles was not working because the transactionRecipient was wrong, this fixs that too

mmv08 and others added 2 commits January 13, 2021 17:28
* Use list instead of programmable navigation

* move color style to appcard

* use color from theme

* add declaration for styled-components theme
@Agupane Agupane self-assigned this Jan 13, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@Agupane Agupane changed the base branch from development to release/v2.18.0 January 13, 2021 17:39
@github-actions
Copy link

github-actions bot commented Jan 13, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1773--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1773--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1773--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1773--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1773--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1773--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

I've checked that The warning message when trying to send a spending limit tx is not longer present

Also another fix was introduced when the warning was being shown before creating a tx to send a collectible.

It looks good to me

@dasanra dasanra merged commit 10f1891 into release/v2.18.0 Jan 14, 2021
@dasanra dasanra deleted the fix/spending-limit-gas-estimation branch January 14, 2021 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants