-
Notifications
You must be signed in to change notification settings - Fork 434
💄 Cosmetic rework for "What are the eight values?" section of index.html #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks great, but ideally should be responsive for mobile devices. |
Glad you like it. I'll see if I can make it responsive |
|
That's odd .. the wrapping effect is not occurring for me on any of the default mobile device emulators listed in Google Chrome (see image below). Would you be able to email me to tell me what phone and browser you are using so I can try and create the error for myself ? (conolaoghaire@gmail.com) |
|
So I'm getting that on Firefox, Ubuntu 20.04. I'm pretty sure using a flexbox would solve that problem really cleanly though. |
|
I managed to recreate the wrapping around bug you encountered. Now the webpage won't wrap around when Firefox's phone emulator is in 'responsive' mode, although it still does not look good. However, I think this issue may be to do with Firefox's emulator, as it does not occur on Firefox if a specific phone emulator (e.g. iPhone 8) is selected, rather than 'responsive' being selected, and also does not occur for the same aspect ratios in Chrome's 'responsive' mode; |
|
👋 Hey, could my branch be pulled? |



I did a cosmetic rework of the "What are the eight values?" section of index.html so as to be more alluring to the eye, and to compliment the style of the values.svg image at the top of the page.
The only non-cosmetic change I made to the section was changing two references to a "State" axis to the "Civil" axis we know and love