Conversation
This API call was added for certain uses cases where killing the process was impractical but internally it just calls `sys.exit()`. Eclair is designed to shutdown cleanly when its process is killed and this is still the recommended way of stopping it.
pm47
reviewed
Apr 12, 2022
| } | ||
| } | ||
|
|
||
| override def stop(exitCode: Int): Future[Unit] = { |
Member
There was a problem hiding this comment.
I wouldn't have provided the exitCode as parameter. We should use 0 as this is a graceful stop.
t-bast
reviewed
Apr 12, 2022
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
Can you add this to the release notes and to eclair-cli?
t-bast
previously approved these changes
Apr 12, 2022
t-bast
approved these changes
Apr 12, 2022
t-bast
added a commit
that referenced
this pull request
Dec 1, 2022
The release introduces a few API changes: - channelbalances retrieves information about the balances of all local channels (#2196) - channelbalances and usablebalances return a shortIds object instead of a single shortChannelId (#2323) - stop stops eclair: please note that the recommended way of stopping eclair is simply to kill its process (#2233) - rbfopen lets the initiator of a dual-funded channel RBF the funding transaction (#2275) - listinvoices and listpendinginvoices now accept --count and --skip parameters to limit the number of retrieved items (#2474)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This API call was added for certain uses cases where killing the process was impractical but internally it just calls
sys.exit().Eclair is designed to shutdown cleanly when its process is killed and this is still the recommended way of stopping it.