Dual funding RBF support#2275
Merged
Merged
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2275 +/- ##
==========================================
+ Coverage 84.67% 84.85% +0.18%
==========================================
Files 199 199
Lines 15472 15584 +112
Branches 640 662 +22
==========================================
+ Hits 13101 13224 +123
+ Misses 2371 2360 -11
🚀 New features to boost your workflow:
|
t-bast
force-pushed
the
dual-funding-rbf
branch
2 times, most recently
from
9b63f8e to
9ea7934
Compare
t-bast
force-pushed
the
dual-funding-rbf
branch
from
9ea7934 to
37123d2
Compare
Add support for bumping the fees of a dual funding transaction. We spawn a transient dedicated actor: if the RBF attempt fails, or if we are disconnected before completing the protocol, we should forget it.
Add more tests for scenarios where an unconfirmed channel is force-closed, where the funding transaction that confirms may not be the last one.
t-bast
force-pushed
the
dual-funding-rbf
branch
from
b514a25 to
4e7d28b
Compare
pm47
reviewed
Aug 22, 2022
t-bast
added a commit
that referenced
this pull request
Dec 1, 2022
The release introduces a few API changes: - channelbalances retrieves information about the balances of all local channels (#2196) - channelbalances and usablebalances return a shortIds object instead of a single shortChannelId (#2323) - stop stops eclair: please note that the recommended way of stopping eclair is simply to kill its process (#2233) - rbfopen lets the initiator of a dual-funded channel RBF the funding transaction (#2275) - listinvoices and listpendinginvoices now accept --count and --skip parameters to limit the number of retrieved items (#2474)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for bumping the fees of a dual funding transaction. We spawn a transient dedicated actor: if the RBF attempt fails, or if we are disconnected before completing the protocol, we should forget it.
With that PR, dual-funding is fully supported by eclair! There is no way for the non-initiator to contribute though, as we'd need a mechanism to let node operators preset some "strategy". The first use-case for contributing as the non-initiator will be liquidity ads, which we will support soon.
Note that I haven't been able to do cross-compatibility tests with cln yet, as their version of dual funding doesn't match the latest state of the spec PR. @niftynei is working on this and I'll do cross-compat tests as soon as they're ready, but I don't think this prevents us from merging this PR to
mastersince dual funding is disabled by default and we've documented that we still may break backwards-compatibility.