Implement first steps of the dual funding flow#2247
Merged
Conversation
This was referenced May 3, 2022
t-bast
force-pushed
the
dual-funding-open-accept
branch
from
902bc7d to
5fdf21c
Compare
pm47
reviewed
May 18, 2022
Member
pm47
left a comment
pm47
left a comment
There was a problem hiding this comment.
Just a first thought, I'll review the rest tomorrow
t-bast
force-pushed
the
dual-funding-open-accept
branch
from
5fdf21c to
0adf29e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2247 +/- ##
==========================================
+ Coverage 84.71% 84.78% +0.07%
==========================================
Files 194 195 +1
Lines 14632 14813 +181
Branches 621 601 -20
==========================================
+ Hits 12395 12559 +164
- Misses 2237 2254 +17
|
pm47
reviewed
May 20, 2022
pm47
reviewed
May 24, 2022
t-bast
force-pushed
the
dual-funding-open-accept
branch
from
3a0d235 to
0065a1a
Compare
Member
Author
|
Rebased to fix conflicts with #2286 |
t-bast
force-pushed
the
dual-funding-open-accept
branch
from
0065a1a to
2e766f4
Compare
Member
Author
|
Rebased to fix conflicts with #2224, I had to squash commits otherwise the rebase was too complex/risky. |
t-bast
force-pushed
the
dual-funding-open-accept
branch
2 times, most recently
from
80ae12f to
be4bf6a
Compare
Member
|
ℹ️ Needs rebase. |
We implement the first step of the dual funding protocol: exchanging `open_channel2` and `accept_channel2`. We currently stop after exchanging these two messages. Future commits will add the interactive-tx protocol used to build the funding transaction.
t-bast
force-pushed
the
dual-funding-open-accept
branch
from
be4bf6a to
de12938
Compare
Member
Author
|
Rebased. |
pm47
reviewed
Aug 9, 2022
pm47
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We implement the first step of the dual funding protocol: exchanging
open_channel2andaccept_channel2.We currently stop after exchanging these two messages.
Future commits will add the
interactive-txprotocol used to build the funding transaction.