Implement interactive-tx construction#2254
Closed
t-bast wants to merge 7 commits into
Closed
Conversation
This is easier to use than having to decide which params we should look into (local or remote). It will also be easier to integrate with dual funding.
This name was very confusing. This feerate only applies to the commit tx, so we make that explicit.
We use a codec trick to make the channelReserve field in LocalParams and RemoteParams an Option[Satoshi].
* Use u16 instead of varint for lengths * Revert channel flags extension * Remove support for non-native segwit inputs
We implement the first step of the dual funding protocol: exchanging `open_channel2` and `accept_channel2`. We currently stop after exchanging these two messages. Future commits will add the interactive-tx protocol used to build the funding transaction.
We build the funding transaction based on the interactive-tx protocol. We currently stop before exchanging signatures. Future commits will add the signature exchange and complete the dual funding flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We build the funding transaction based on the
interactive-txprotocol. We currently stop before exchanging signatures. Future commits will add the signature exchange and complete the dual funding flow.NB: this builds on top of #2247