Skip to content

Pagination for channelstats RPC#2890

Merged
t-bast merged 3 commits intoACINQ:masterfrom
rorp:channelstats_pagination
Aug 1, 2024
Merged

Pagination for channelstats RPC#2890
t-bast merged 3 commits intoACINQ:masterfrom
rorp:channelstats_pagination

Conversation

@rorp
Copy link
Contributor

@rorp rorp commented Jul 28, 2024

No description provided.

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can you update the release notes to mention that this API now provides pagination, to ensure that we correctly document it with the next release?

@rorp rorp requested a review from t-bast August 1, 2024 00:55
@t-bast t-bast merged commit c45d278 into ACINQ:master Aug 1, 2024
t-bast added a commit that referenced this pull request Dec 4, 2024
This release introduces a few API changes:

- `channelstats` now takes optional parameters `--count` and `--skip`
  to control pagination. By default, it will return the first 10
  entries (#2890)
- `createinvoice` now takes an optional `--privateChannelIds` parameter
  that can be used to add routing hints through private channels (#2909)
- `nodes` allows filtering nodes that offer liquidity ads (#2848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants