Allow including routing hints when creating Bolt 11 invoice#2909
Merged
Allow including routing hints when creating Bolt 11 invoice#2909
Conversation
When nodes only have private channels, they must include routing hints in their Bolt 11 invoices to be able to receive payments. We add a parameter to the `createinvoice` RPC for this. Note that this may leak the channel outpoint if `scid_alias` isn't used. Fixes #2802
Contributor
thomash-acinq
left a comment
thomash-acinq
left a comment
There was a problem hiding this comment.
Looks good, there is just a TODO left.
thomash-acinq
approved these changes
Sep 23, 2024
t-bast
added a commit
that referenced
this pull request
Dec 4, 2024
This release introduces a few API changes: - `channelstats` now takes optional parameters `--count` and `--skip` to control pagination. By default, it will return the first 10 entries (#2890) - `createinvoice` now takes an optional `--privateChannelIds` parameter that can be used to add routing hints through private channels (#2909) - `nodes` allows filtering nodes that offer liquidity ads (#2848)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When nodes only have private channels, they must include routing hints in their Bolt 11 invoices to be able to receive payments. We add a parameter to the
createinvoiceRPC for this. Note that this may leak the channel outpoint ifscid_aliasisn't used.Fixes #2802