Extended Queries: use TLV format for optional data#972
Closed
sstone wants to merge 27 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## extended-queries-optional #972 +/- ##
===========================================================
+ Coverage 73.89% 82.7% +8.8%
===========================================================
Files 125 98 -27
Lines 8474 7660 -814
Branches 314 289 -25
===========================================================
+ Hits 6262 6335 +73
+ Misses 2212 1325 -887
|
Member
|
This probably needs to be rebased from #1045. |
Member
* Reject payments for expired invoices
It is functionnaly the same but it's cleaner and removes the need for tuples in the success case.
* Add eclair-cli to eclair's docker image * Add instructions to use eclair-cli inside the docker container
Hide some internals (tlvFallback, generictlv codecs). Add a length-prefixed tlv stream codec.
This tests was checking that we could read extended `query_short_channel_ids`, with an optional list of query flags. This optional type is now a TLV, and its type is 1 (and not 0 as previously defined here)
All the data contained in `node_announcement`, `channel_announcement` and `channel_update` is to be included in the signature, including unknown trailing fields. We were ignoring them, causing signature verification to fail when there was unknown fields. In the case of `channel_update` there is a backward compatibility issue to handle, because when persisting channel data in state `NORMAL`, we used to store the `channel_update` followed by other data, and without prefixing it with size information. To work around that we use the same trick as before, based on an additional discriminator codec.
Checkpoints generated on July 9th 2019
* Wrap all routes in toStrictEntity
pm47
reviewed
Jul 10, 2019
We now define TLV classes `type` property in their companion object.
This PR adds support for truncated integers as defined in the spec. The test vectors are updated to include all test vectors from rusty's spec PR. It also provides many changes to the tlv and tlv stream classes: - The tlv trait doesn't need a type field, the codec should handle that - A TLV stream should be scoped to a specific subtrait of tlv - Stream validation is done inside the codec instead of the tlv stream: it makes it more convenient for application layers to create tlv streams and manipulate them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RFC PR has already been updated, and this adds more flexibility as node that don't understand some fields can just skip over them. Timestamps and checksums have also been separated.