Skip to content

Changes to align the I/O Coherency tests with the rules in specs #103

@sunnywang-arm

Description

@sunnywang-arm

@anncheng-arm and I found an issue related to how I/O Coherency tests are handled in the BSA and SBSA test suites.

In the latest BSA and SBSA specs, the rules in BSA section E.8 (PCI_IC_xx) are all conditional requirements, which means I/O Coherency is not a hard requirement for BSA compliance. However, the test https://github.com/ARM-software/sysarch-acs/blob/main/test_pool/exerciser/e007.c is still executed unconditionally in the BSA test suite, which seems incorrect.

We had used the issue and pull request below to update the test suite for this, but some changes are still missing in the test suite.

In SBSA, the rule S_PCIe_09 is used to mandate I/O Coherency - S_PCIe_09 in the SBSA spec is a parent/umbrella rule over all I/O Coherency related rules (PCI_IC_xx) in the BSA spec. Given that, we propose the changes below:

  • Replace rule ID PCI_IC_11 with S_PCIe_09
  • Move "Check PCIe I/O Coherency" test (e007.c) from BSA to SBSA (checklist files, bsa_execute_test.c, and sbsa_execute_test.c)

Metadata

Metadata

Labels

bsaBase System Architecture ACS specific issues/enhancements/questions.

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions