Skip to content

Consider using a plugin hook rather than explicit "logError" parameter for withTogglePointFactory in "react pointcuts" package #42

@TomStrepsil

Description

@TomStrepsil

The withTogglePointFactory accepts a logError argument, for logging errors when an ErrorBoundary catches errors within variant code.

This is currently mandatory, which may not be suitable for all consumers.

Also, this side-effect could be aligned with the "plugin" concept, currently only used for a "code selection" hook, but perhaps would be more consistent if a onError hook was added, to which plugins could listen for logging purposes, or otherwise.

Relates to #30

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions