Skip to content

[42] move logError argument of withTogglePointFactory to plugin hook #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asos-dominicjomaa merged 17 commits into from
Oct 20, 2025
Merged

[42] move logError argument of withTogglePointFactory to plugin hook #44

asos-dominicjomaa merged 17 commits into from
Oct 20, 2025

Conversation

@TomStrepsil
Copy link
Contributor

@TomStrepsil TomStrepsil commented Jul 6, 2025 •
edited
Loading

Issue

resolves #42
enables #30

Details

Support a new onVariantError plugin hook, replacing the mandatory logError callback passed to the withTogglePointFactory of the react-pointcuts package, thus making the side-effect logging-agnostic, and optional.

Scout Rule

CheckList

  • PR starts with [ISSUE_ID].
  • Has been tested (where required) before merge to main.

TomStrepsil and others added 6 commits December 24, 2024 17:31
@TomStrepsil
change initial commit message in changelogs (#3)
d0ce7f1
@TomStrepsil
[ASOS#18] Fix JSDoc module names (ASOS#19)
27e436a 
* rename to proper module namespace

* update docs links

* update versions

* web toggle point in readme title

* fixup changelog from revised 0.x range

* 2.0.0 -> 0.5.0 in oss version scheme

* fix broken link syntax in CHANGELOG

* consistent quoting

* more version history issues

* fixup module name in jsdoc

* add web
remove sdkInstanceProvider

* remove SDKInstanceProvider

* fixup jsdoc dedupe

* tweak

* clarity re: ssr package

* casing etc
@TomStrepsil @jlptom
[26] Fix public/scoped package publishing (ASOS#27)
1f0cb29 
* update workflows

* version

* typo

* update chromium linux snaps

* versions for serve update

* package.json repository field

* update root package.lock

* bugs & directories/doc fields

* fix changelog

---------

Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
@TomStrepsil @jlptom
fix registry url etc (ASOS#34)
d85e398 
Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
@TomStrepsil
Merge branch 'main' of github.com:TomStrepsil/web-toggle-point
cd2fc82
@TomStrepsil
logError -> onVariantError
bbb31ad
@TomStrepsil TomStrepsil changed the title [42] move log error to plugin hook [42] move logError to plugin hook Jul 6, 2025
@TomStrepsil TomStrepsil changed the title [42] move logError to plugin hook [42] move logError argument of withTogglePointFactory to plugin hook Jul 6, 2025
@TomStrepsil TomStrepsil requested a review from a team as a code owner July 14, 2025 09:54
@TomStrepsil TomStrepsil mentioned this pull request Sep 3, 2025
Open
@asos-dominicjomaa asos-dominicjomaa merged commit daed26d into ASOS:main Oct 20, 2025
10 checks passed
@TomStrepsil TomStrepsil deleted the feature/42-move-log-error-to-plugin-hook branch October 21, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asos-dominicjomaa asos-dominicjomaa asos-dominicjomaa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider using a plugin hook rather than explicit "logError" parameter for withTogglePointFactory in "react pointcuts" package

2 participants

@TomStrepsil @asos-dominicjomaa