[18] Fix JSDoc module names #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 8 out of 23 changed files in this pull request and generated no comments.
Files not reviewed (15)
- packages/features/package.json: Language not supported
- packages/react-pointcuts/package.json: Language not supported
- packages/ssr/package.json: Language not supported
- packages/ssr/docs/CHANGELOG.md: Evaluated as low risk
- packages/react-pointcuts/docs/CHANGELOG.md: Evaluated as low risk
- packages/react-pointcuts/docs/README.md: Evaluated as low risk
- packages/react-pointcuts/src/getCodeSelectionPlugins.js: Evaluated as low risk
- packages/features/src/reactContext/store.js: Evaluated as low risk
- packages/features/src/ssrBackedReactContext/store.js: Evaluated as low risk
- packages/react-pointcuts/src/withTogglePointFactory/index.js: Evaluated as low risk
- packages/react-pointcuts/src/withToggledHookFactory/index.js: Evaluated as low risk
- packages/features/src/global/store.js: Evaluated as low risk
- packages/features/src/nodeRequestScoped/store.js: Evaluated as low risk
- packages/ssr/src/withJsonIsomorphism/index.js: Evaluated as low risk
- packages/features/src/global.js: Evaluated as low risk
There was a problem hiding this comment.
Copilot reviewed 11 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (15)
- package.json: Language not supported
- packages/features/package.json: Language not supported
- packages/react-pointcuts/package.json: Language not supported
- packages/ssr/package.json: Language not supported
- docs/CHANGELOG.md: Evaluated as low risk
- docs/README.md: Evaluated as low risk
- packages/features/docs/CHANGELOG.md: Evaluated as low risk
- packages/features/docs/README.md: Evaluated as low risk
- packages/features/src/global.js: Evaluated as low risk
- packages/features/src/global/store.js: Evaluated as low risk
- packages/features/src/nodeRequestScoped/store.js: Evaluated as low risk
- packages/features/src/reactContext/store.js: Evaluated as low risk
- packages/react-pointcuts/src/withToggledHookFactory/index.js: Evaluated as low risk
- packages/react-pointcuts/src/withTogglePointFactory/index.js: Evaluated as low risk
- packages/features/src/ssrBackedReactContext/store.js: Evaluated as low risk
asos-domhoare
approved these changes
Jan 29, 2025
asos-danielc
approved these changes
Jan 29, 2025
TomStrepsil
added a commit
to TomStrepsil/web-toggle-point
that referenced
this pull request
Apr 10, 2025
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
asos-dominicjomaa
pushed a commit
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
18
Details
Rename all instances of
asos-web-toggle-pointortoggle-pointtoweb-toggle-pointin the JSDoc comments.Also
README.mdto match the naming of "Web Toggle Point"CHANGELOG.mdentry for re-imagined version history.CHANGELOG.mdsdkInstanceProvidersignature from JSDocexternal.js, no longer a thing after extraction of Optimizely packagededupeExternalJsdocPlugin, a change in0.5.0has regressed, believe to be after move to a typescript-savvy imported typedef.CheckList
main.