-
Notifications
You must be signed in to change notification settings - Fork 1
[5] Support Multiple Variant Globs #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
asos-dominicjomaa
merged 12 commits into
ASOS:main
from
TomStrepsil:feature/5-support-multiple-variant-globs
Jul 14, 2025
Merged
[5] Support Multiple Variant Globs #40
asos-dominicjomaa
merged 12 commits into
ASOS:main
from
TomStrepsil:feature/5-support-multiple-variant-globs
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
A few cherry-picks from ASOS#21...
asos-dominicjomaa
approved these changes
Jul 14, 2025
jackiedunne
approved these changes
Jul 14, 2025
jackiedunne
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #5
Details
variantGlobtovariantGlobsin the configuration of the webpack plugin.getVariantFilesmodule becomesgetVariantPaths, returning aSetrather than array of objects. The separation ofnameandpath(just to save unpicking this later) has been replaced for a simpler collection of paths, with the separation now happening at time of need inprocessVariantFilesusingparse.filename,directoryetc.variantGlobs, to cover support of such, and provide inspiration for those that may prefer this form.Scout Rule:
variantGlobtoprocessVariantFilesinprocessPointCutswebpackpackageREADME.md("sinlge" -> "single")Upgrade guide
This change will represent breaking changes in consumers of the webpack package.
The point cut configuration needs to be modified for the plugin thus:
variantGloboption key is renamed tovariantGlobs, and its value should be wrapped in[]CheckList
main.