[28] Fix flaky Playwright image snapshot tests #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
TomStrepsil
commented
Feb 28, 2025
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
…l/web-toggle-point into fix/28-playwright-fuzzy-image
…l/web-toggle-point into fix/28-playwright-fuzzy-image
TomStrepsil
force-pushed
the
fix/28-playwright-fuzzy-image
branch
from
e695177 to
5bbe689
Compare
asos-dominicjomaa
approved these changes
Jul 14, 2025
…l/web-toggle-point into fix/28-playwright-fuzzy-image
This reverts commit 61d2c30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #28
Details
This PR attempts to loosen the strict binary checking that is causing newer versions of Chromium Linux to produce false negatives. By setting a 0.05
maxDiffPixelRatio, this should mitigate the0.04ratio thrown up by the Linux Chromium upgrade. May need further tweaking in future, but given a0.01headroom atop this example failure.Scout Rule:
@reduxjs/toolkitpeer dependency of thefeaturespackage, this was a remnant of an endeavour to provide a redux-specific features store, but this was not created in the end, and this was left in place mistakenly.react-domdependency of thefeaturesandreact-pointcutspackages, this stopped being a thing when thessrpackage was extractedCheckList
main.