Skip to content

[Classic] Fix a parse warning with small eggs + [Classic] Corrected note and lockcriteria to Rig Wars 2841 and Chief Engineer Scooty 2842 #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milotic wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −11
Open

[Classic] Fix a parse warning with small eggs + [Classic] Corrected note and lockcriteria to Rig Wars 2841 and Chief Engineer Scooty 2842 #2254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .contrib/Parser/DATAS/01 - Dungeons Raids/01 - Classic/Gnomeregan.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ root(ROOTS.Instances, expansion(EXPANSION.CLASSIC, {
["lvl"] = 25,
}),
q(2842, { -- Chief Engineer Scooty
["description"] = "You cannot get this quest until you accept the Rig Wars quest. Accept Rig Wars, then this guy gives you the quest to get to Gnomer safely...",
["description"] = "Although this quest is available from level 20, if you take or complete it, it makes it impossible to obtain the 'Rig Wars' quest, which is available at level 25. However, if you take 'Rig Wars' first, you can have both quest without problems.",
["qg"] = 3413, -- Sovik <Engineering Supplies>
["coord"] = { 75.6, 25.2, ORGRIMMAR },
["timeline"] = { REMOVED_4_0_3 },
Expand Down Expand Up @@ -615,6 +615,7 @@ root(ROOTS.Instances, expansion(EXPANSION.CLASSIC, {
["coord"] = { 75.8, 25.2, ORGRIMMAR },
["timeline"] = { REMOVED_4_0_3 },
["races"] = HORDE_ONLY,
["lockCriteria"] = { 1, "questID", 2842 },
["lvl"] = 25,
["groups"] = {
objective(1, { -- 0/1 Rig Blueprints
Expand Down
16 changes: 7 additions & 9 deletions .contrib/Parser/DATAS/03 - World Drops/01 Rooted/1 - Classic.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5408,15 +5408,13 @@ root(ROOTS.WorldDrops, expansion(EXPANSION.CLASSIC, {
}),
i(6889, { -- Small Egg
-- #if BEFORE 4.0.3
["coord"] = { 44.0, 48.0, DARKSHORE },
["maps"] = {
DARKSHORE,
LOCH_MODAN,
MULGORE,
REDRIDGE_MOUNTAINS,
TELDRASSIL,
THE_BARRENS,
WESTFALL,
["coord"] = {
{ 44.0, 48.0, DARKSHORE },
{ 76.6, 68.2, LOCH_MODAN },
{ 40.6, 59.0, MULGORE },
{ 52.0, 38.8, REDRIDGE_MOUNTAINS },
{ 54.6, 60.6, TELDRASSIL },
{ 61.2, 59.8, WESTFALL },
Comment on lines +5416 to +5417
Copy link
Collaborator

@ImUnicke ImUnicke Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No coord for THE_BARRENS ?

},
-- #endif
-- #if AFTER TBC
Expand Down
2 changes: 1 addition & 1 deletion .contrib/Parser/DATAS/09 - Crafted Items/05 - Mists of Pandaria.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ root(ROOTS.Craftables, expansion(EXPANSION.MOP, applyclassicphase(MOP_PHASE_ONE,
i(74728), -- Enchant Weapon - River's Song
i(74723), -- Enchant Weapon - Windsong
-- #if ANYCLASSIC
applyclassicphase(MOP_PHASE_RISE_OF_THE_THUNDER_KING,i(254314, {["timeline"] = {ADDED_5_5_1}})), -- Enchant Weapon - Tyrann
applyclassicphase(MOP_PHASE_RISE_OF_THE_THUNDER_KING,i(254314, {["timeline"] = {ADDED_5_5_1}})), -- Enchant Weapon - Tyranny
-- #endif
}),
}),
Expand Down