fix: Make the test focus event handler thread-safe again#306
Merged
Conversation
DataTriny
approved these changes
Nov 4, 2023
Member
DataTriny
left a comment
DataTriny
left a comment
There was a problem hiding this comment.
The newtype struct really make things clearer.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that the recent switch from
ArctoRcin this event handler was incorrect, because the event handler is in fact called from a different thread from the one on which it was created. To address the original clippy warning in the safest way possible, I created a new wrapper struct,SendableUiaElement, that implementsSend. The compiler can automatically implementSendandSynconReceivedFocusEventfrom there. I also added a static assertion thatSendandSyncare implemented onFocusEventHandler.