fix!: Rename accesskit_winit::Adapter::on_event to process_event#307
Merged
mwcampbell merged 1 commit intomainfrom Nov 4, 2023
Merged
fix!: Rename accesskit_winit::Adapter::on_event to process_event#307mwcampbell merged 1 commit intomainfrom
accesskit_winit::Adapter::on_event to process_event#307mwcampbell merged 1 commit intomainfrom
Conversation
Member
Author
|
The two same tests are failing again. Looks like #306 didn't change anything afterall. |
Contributor
|
OK, we'll revisit event filtering if and when we actually implement a self-voicing adapter. |
Merged
|
Thanks, y'all rock <3 |
Contributor
|
@alice-i-cecile What are Bevy's plans for updating to winit 0.29? I was just wondering if we need to backport this fix to another accesskit_winit release that still uses winit 0.28. |
|
We'll be upgraded to 0.29 by the next Bevy release. It's a complex migration, but hotly desired. @Vrixyz has been leading those efforts |
Contributor
|
OK, then I gather it's not necessary to backport this API fix for winit 0.28. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #300
The name
on_eventsuggests that this function won't have side effects, which is not the case.We received strong push-back from developers who don't want AccessKit to filter events. We previously agreed on keeping the mechanism around even though we didn't use it for keyboard events on Unix. Even though we might need it in the future for other features, this is not currently the case, therefore it is hard to convince people to use it. I propose to remove it for now.