Skip to content

Conversation

@C-Achard
Copy link
Collaborator

@C-Achard C-Achard commented Nov 16, 2023

This PR aims to fix all issues with M1/2/... install on Mac by providing a correct install procedure and conda yaml file.

  • Documentation update

@C-Achard C-Achard added documentation Improvements or additions to documentation fix Something needs to be or has been fixed requirements Related to installation requirements and optional dependencies labels Nov 16, 2023
@C-Achard C-Achard self-assigned this Nov 16, 2023
@C-Achard C-Achard marked this pull request as ready for review November 21, 2023 15:14
@C-Achard
Copy link
Collaborator Author

Fixed ARM64 install for itk and fixed some non OS-agnostic tests

@C-Achard C-Achard requested review from CYHSM and MMathisLab November 21, 2023 15:15
@C-Achard
Copy link
Collaborator Author

Will test this a bit more on our M1 server, but should be good now

@C-Achard C-Achard marked this pull request as draft November 21, 2023 15:16
@C-Achard C-Achard marked this pull request as ready for review November 21, 2023 15:22
@C-Achard C-Achard requested a review from Timokleia November 21, 2023 15:40
@C-Achard
Copy link
Collaborator Author

@Timokleia If you confirm this works you can approve the PR !

@C-Achard C-Achard changed the base branch from cy/training to cy/feedback-fixes November 22, 2023 10:27
@C-Achard C-Achard mentioned this pull request Nov 22, 2023
5 tasks
@C-Achard C-Achard merged commit 254d7fd into cy/feedback-fixes Dec 5, 2023
C-Achard added a commit that referenced this pull request Dec 5, 2023
* Update plugin_convert.py

* Update plugin_convert.py

* Update plugin_convert.py

* Update napari_cellseg3d_m1.yml

* Fix memory allocation issue

* Add debug info to stats

* Add mini-stats test

* TEMP Comment out image stats

* Revert "TEMP Comment out image stats"

This reverts commit fc73e5b.

* Disable image deletion

* Disable sphericity

* Add sphericity

* Add *.tiff as valid path everywhere

* Fix tests and tif+tiff loading

* Fix several test issues and inconsistencies

* Update .gitignore

* Move pydensecrf back to main repo

* Update worker_inference.py

* Update worker_inference.py

* Update worker_inference.py

* Reduce warning spam in stats

* Update instance_segmentation.py

* Update utils.py

* Update instance_segmentation.py

* Fix attr error in inference

* Add artifact removal (#60)

* WIP add artifact removal

* Add utils and inference worker artifact removal

* Fix issue with layer type in utils

* Add better pbar and windowed artifact rem

* Refactor results name to be more explicit

* Add working pbar to Inference log

* Reduce requirements

* Fix spheric. test and import checking

* Update worker_training.py

* Update worker_training.py

* macOS Silicon install (#59)

* Remove itk temp

* Update napari_cellseg3d_m1.yml

* Update napari_cellseg3d_m1.yml

* Remove duplicate imagecodecs

* Update napari_cellseg3d_m1.yml

* Remove imagecodecs TEMP

* Fixing tests on M1

* Remove erroneous path in test

* Update test_utils.py

* Update test_utils.py

* Changed  python to 3.9 for ITK

* Docs update

* Minor docs tweaks

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* README and docs update

* Labels stats notebook update

* mv full plot to better name

* Fix attr error in inference
@C-Achard C-Achard deleted the cy/m1-install branch December 14, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fix Something needs to be or has been fixed requirements Related to installation requirements and optional dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants