Skip to content

DPL GUI: add compatibility with DebugGUI v0.7.0#10546

Merged
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:support-debug-gui-v0.7.0
Jan 13, 2023
Merged

DPL GUI: add compatibility with DebugGUI v0.7.0#10546
ktf merged 1 commit intoAliceO2Group:devfrom
ktf:support-debug-gui-v0.7.0

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Jan 11, 2023

No description provided.

@ktf ktf requested a review from a team as a code owner January 11, 2023 13:53
@ktf
Copy link
Copy Markdown
Member Author

ktf commented Jan 11, 2023

Hopefully the ImPlot we ship already had the new API available, but I am not sure 100% of the changes (most notably the lambda argument swap) were backward compatible. I guess I will add ifdefs otherwise...

@davidrohr you will need this and AliceO2Group/DebugGUI#43. The macOS version seems to work (I am still testing), so maybe it's not so bad after all. I also added the vulkan backend to our distribution, so maybe we can switch to it everywhere.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for 30da165 at 2023-01-11 18:07:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:252:15: error: 'SetNextAxisLimits' is not a member of 'ImPlot'; did you mean 'SetNextPlotLimits'?
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:252:33: error: 'ImAxis_X1' was not declared in this scope
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:253:15: error: 'SetNextAxisLimits' is not a member of 'ImPlot'; did you mean 'SetNextPlotLimits'?
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:253:33: error: 'ImAxis_Y1' was not declared in this scope
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:257:15: error: 'SetAxis' is not a member of 'ImPlot'
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:269:39: error: invalid user-defined conversion from 'o2::framework::gui::displaySparks(double, std::vector<o2::framework::gui::MetricIndex>&, std::vector<o2::framework::gui::MetricDisplayState>&, const o2::framework::gui::AllMetricsStore&)::<lambda(int, void*)>' to 'ImPlotPoint (*)(void*, int)' [-fpermissive]
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:281:39: error: invalid user-defined conversion from 'o2::framework::gui::displaySparks(double, std::vector<o2::framework::gui::MetricIndex>&, std::vector<o2::framework::gui::MetricDisplayState>&, const o2::framework::gui::AllMetricsStore&)::<lambda(int, void*)>' to 'ImPlotPoint (*)(void*, int)' [-fpermissive]
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:293:39: error: invalid user-defined conversion from 'o2::framework::gui::displaySparks(double, std::vector<o2::framework::gui::MetricIndex>&, std::vector<o2::framework::gui::MetricDisplayState>&, const o2::framework::gui::AllMetricsStore&)::<lambda(int, void*)>' to 'ImPlotPoint (*)(void*, int)' [-fpermissive]
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:305:39: error: invalid user-defined conversion from 'o2::framework::gui::displaySparks(double, std::vector<o2::framework::gui::MetricIndex>&, std::vector<o2::framework::gui::MetricDisplayState>&, const o2::framework::gui::AllMetricsStore&)::<lambda(int, void*)>' to 'ImPlotPoint (*)(void*, int)' [-fpermissive]
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:436:11: error: 'SetNextAxisLimits' is not a member of 'ImPlot'; did you mean 'SetNextPlotLimits'?
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:436:29: error: 'ImAxis_X1' was not declared in this scope
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:442:11: error: 'SetNextAxisLimits' is not a member of 'ImPlot'; did you mean 'SetNextPlotLimits'?
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:442:29: error: 'ImAxis_Y1' was not declared in this scope
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:444:11: error: 'SetNextAxisLimits' is not a member of 'ImPlot'; did you mean 'SetNextPlotLimits'?
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:446:11: error: 'SetNextAxisLimits' is not a member of 'ImPlot'; did you mean 'SetNextPlotLimits'?
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:456:36: error: invalid user-defined conversion from 'o2::framework::gui::displayDeviceMetrics(const char*, size_t, size_t, size_t, o2::framework::gui::MetricsDisplayStyle, std::vector<o2::framework::gui::MetricDisplayState>&, const o2::framework::gui::AllMetricsStore&)::<lambda(int, void*)>' to 'ImPlotPoint (*)(void*, int)' [-fpermissive]
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:471:19: error: 'SetAxis' is not a member of 'ImPlot'
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:472:43: error: invalid user-defined conversion from 'o2::framework::gui::displayDeviceMetrics(const char*, size_t, size_t, size_t, o2::framework::gui::MetricsDisplayStyle, std::vector<o2::framework::gui::MetricDisplayState>&, const o2::framework::gui::AllMetricsStore&)::<lambda(int, void*)>' to 'ImPlotPoint (*)(void*, int)' [-fpermissive]
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:485:82: error: invalid user-defined conversion from 'o2::framework::gui::displayDeviceMetrics(const char*, size_t, size_t, size_t, o2::framework::gui::MetricsDisplayStyle, std::vector<o2::framework::gui::MetricDisplayState>&, const o2::framework::gui::AllMetricsStore&)::<lambda(int, void*)>' to 'ImPlotPoint (*)(void*, int)' [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

@ktf ktf force-pushed the support-debug-gui-v0.7.0 branch from 30da165 to 29512de Compare January 12, 2023 20:55
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI for 29512de at 2023-01-12 23:37:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/10546-slc8_x86-64/0/Framework/GUISupport/src/FrameworkGUIDebugger.cxx:29:2: error: invalid preprocessing directive #warn; did you mean #warning?
ninja: build stopped: subcommand failed.

Full log here.

@ktf ktf force-pushed the support-debug-gui-v0.7.0 branch from 29512de to a40981c Compare January 13, 2023 07:59
@ktf ktf merged commit 7697d1a into AliceO2Group:dev Jan 13, 2023
@ktf ktf deleted the support-debug-gui-v0.7.0 branch January 13, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants