Skip to content

Bump to ImGUI v1.89.2 and ImPlot v0.14#43

Merged
ktf merged 2 commits intoAliceO2Group:masterfrom
ktf:bump-latest-imgui
Jan 12, 2023
Merged

Bump to ImGUI v1.89.2 and ImPlot v0.14#43
ktf merged 2 commits intoAliceO2Group:masterfrom
ktf:bump-latest-imgui

Conversation

@ktf
Copy link
Copy Markdown
Member

@ktf ktf commented Jan 11, 2023

No description provided.

@ktf
Copy link
Copy Markdown
Member Author

ktf commented Jan 11, 2023

Seems to work on mac. Waiting for @davidrohr to confirm everything is fine on Linux.

@davidrohr
Copy link
Copy Markdown
Contributor

Trying to compile this PR, this file is missing: https://github.com/ocornut/imgui/blob/v1.89.2/backends/imgui_impl_opengl3_loader.h
I added it locally, and now the compilation is failing with

I/libO2DebugGUI.so  /usr/lib64/libglfw.so.3.3 && :
2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: DebugGUI/libO2DebugGUI.so: undefined reference to `ImGui_ImplGlfwGL3_RenderDrawLists(ImDrawData*)'
2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: DebugGUI/libO2DebugGUI.so: undefined reference to `ImGui_ImplGlfwGL3_Init(GLFWwindow*, bool)'
2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: DebugGUI/libO2DebugGUI.so: undefined reference to `ImGui_ImplGlfwGL3_Shutdown()'
2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: DebugGUI/libO2DebugGUI.so: undefined reference to `ImGui_ImplGlfwGL3_NewFrame()'

and

2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: DebugGUI/CMakeFiles/imgui_demo.dir/test/test_ImGUI.cpp.o: in function `main':
2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /home/qon/alice/sw/SOURCES/DebugGUI/v0.6.8/0/DebugGUI/test/test_ImGUI.cpp:33: undefined reference to `ImGui_ImplGlfwGL3_Init(GLFWwindow*, bool)'
2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: /home/qon/alice/sw/SOURCES/DebugGUI/v0.6.8/0/DebugGUI/test/test_ImGUI.cpp:56: undefined reference to `ImGui_ImplGlfwGL3_NewFrame()'
2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: /home/qon/alice/sw/SOURCES/DebugGUI/v0.6.8/0/DebugGUI/test/test_ImGUI.cpp:106: undefined reference to `ImGui_ImplGlfwGL3_Shutdown()'
2023-01-11@18:24:01:DEBUG:O2PDPSuite:DebugGUI:0: /usr/lib/gcc/x86_64-pc-linux-gnu/12/../../../../x86_64-pc-linux-gnu/bin/ld: DebugGUI/libO2DebugGUI.so: undefined reference to `ImGui_ImplGlfwGL3_RenderDrawLists(ImDrawData*)'

@ktf ktf force-pushed the bump-latest-imgui branch from 78a6624 to 28c8f00 Compare January 12, 2023 10:54
@ktf ktf force-pushed the bump-latest-imgui branch from d7cc4fe to 3a9f851 Compare January 12, 2023 12:28
@ktf ktf merged commit 6622148 into AliceO2Group:master Jan 12, 2023
@ktf ktf deleted the bump-latest-imgui branch January 12, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants