-
Notifications
You must be signed in to change notification settings - Fork 622
[event plane] update labeling for TPC #6861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Error while checking build/O2Physics/o2 for f0bb42d at 2024-07-15 17:50: Full log here. |
|
@jikim1290 I fear that you have to do the same change also in the tasks that are currently using the Q-vector tables. |
a9304ee
|
Dear @jikim1290 , Thank your for changes. It looks good from PWG-EM. |
lucamicheletti93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @jikim1290 , thanks a lot! See my comment here: https://github.com/AliceO2Group/O2Physics/pull/6861/files#r1686233799
Please consider the following formatting changes to AliceO2Group#6861
|
Error while checking build/O2Physics/o2 for c4f935b at 2024-07-22 16:04: Full log here. |
|
Error while checking build/O2Physics/o2 for c57c4db at 2024-07-22 17:51: Full log here. |
|
Dear @jikim1290, |
|
@strogolo I copied the mail to get your response: If I understand correctly, you want to change labelling for all PWGs tasks as well. In conclusions, one should state global agreement that no one can resist |
|
Dear @jikim1290, |
| DECLARE_SOA_COLUMN(QvecTPCposReVec, qvecTPCposReVec, std::vector<float>); | ||
| DECLARE_SOA_COLUMN(QvecTPCposImVec, qvecTPCposImVec, std::vector<float>); | ||
| DECLARE_SOA_COLUMN(QvecTPCnegReVec, qvecTPCnegReVec, std::vector<float>); | ||
| DECLARE_SOA_COLUMN(QvecTPCnegImVec, qvecTPCnegImVec, std::vector<float>); | ||
| DECLARE_SOA_COLUMN(QvecTPCallReVec, qvecTPCallReVec, std::vector<float>); | ||
| DECLARE_SOA_COLUMN(QvecTPCallImVec, qvecTPCallImVec, std::vector<float>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use proper camelCase for good readability. Qvec, Cpos, Cneg, Call are not words nor abbreviations.
| DECLARE_SOA_COLUMN(QvecTPCposReVec, qvecTPCposReVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QvecTPCposImVec, qvecTPCposImVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QvecTPCnegReVec, qvecTPCnegReVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QvecTPCnegImVec, qvecTPCnegImVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QvecTPCallReVec, qvecTPCallReVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QvecTPCallImVec, qvecTPCallImVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QVecTpcPosReVec, qVecTpcPosReVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QVecTpcPosImVec, qVecTpcPosImVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QVecTpcNegReVec, qVecTpcNegReVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QVecTpcNegImVec, qVecTpcNegImVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QVecTpcAllReVec, qVecTpcAllReVec, std::vector<float>); | |
| DECLARE_SOA_COLUMN(QVecTpcAllImVec, qVecTpcAllImVec, std::vector<float>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This applies to all other name changes too.
|
Dear @jikim1290, Thanks. |
|
Closed after PR #7199 was merged. |
update labeling for TPC