Skip to content

Labeling changed #7165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaximVirta wants to merge 2 commits into from
Closed

Labeling changed #7165

MaximVirta wants to merge 2 commits into from

Conversation

@MaximVirta
Copy link
Contributor

@MaximVirta MaximVirta commented Aug 5, 2024

Follow-up PR from 6861
Should be closed if the other is merged.

All of the following occurances have been changed

"BPos" => "TPCpos"
"BNeg" => "TPCneg"
"BTot" => "TPCall"

@MaximVirta MaximVirta requested review from a team, ddobrigk and ktf as code owners August 5, 2024 14:20
@alibuild
Copy link
Collaborator

alibuild commented Aug 5, 2024 •
edited
Loading

Error while checking build/O2Physics/o2 for 474e7eb at 2024-08-06 07:48:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:96:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:97:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:98:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:96:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:97:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:98:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:96:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:97:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:98:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:96:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:97:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:98:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:96:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:97:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:98:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Aug 6, 2024 •
edited
Loading

Error while checking build/O2Physics/o2 for 9529b4e at 2024-08-07 06:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:96:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:97:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:98:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:96:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:97:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
/sw/SOURCES/O2Physics/7165-slc7_x86-64/0/Common/DataModel/Qvectors.h:98:45: error: initializer-string for 'const char [16]' is too long [-fpermissive]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera requested changes Aug 6, 2024
View reviewed changes
Common/DataModel/Qvectors.h
Comment on lines +46 to +51
DECLARE_SOA_COLUMN(QvecTPCposReVec, qvecTPCposReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCposImVec, qvecTPCposImVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCnegReVec, qvecTPCnegReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCnegImVec, qvecTPCnegImVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCallReVec, qvecTPCallReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCallImVec, qvecTPCallImVec, std::vector<float>);
Copy link
Collaborator

@vkucera vkucera Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use proper camelCase for good readability. Qvec, Cpos, Cneg, Call are not words nor abbreviations.

Suggested change
DECLARE_SOA_COLUMN(QvecTPCposReVec, qvecTPCposReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCposImVec, qvecTPCposImVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCnegReVec, qvecTPCnegReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCnegImVec, qvecTPCnegImVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCallReVec, qvecTPCallReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QvecTPCallImVec, qvecTPCallImVec, std::vector<float>);
DECLARE_SOA_COLUMN(QVecTpcPosReVec, qVecTpcPosReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QVecTpcPosImVec, qVecTpcPosImVec, std::vector<float>);
DECLARE_SOA_COLUMN(QVecTpcNegReVec, qVecTpcNegReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QVecTpcNegImVec, qVecTpcNegImVec, std::vector<float>);
DECLARE_SOA_COLUMN(QVecTpcAllReVec, qVecTpcAllReVec, std::vector<float>);
DECLARE_SOA_COLUMN(QVecTpcAllImVec, qVecTpcAllImVec, std::vector<float>);

This applies to all other name changes too.

@strogolo
Copy link
Collaborator

strogolo commented Aug 7, 2024

Dear @MaximVirta,
after the discussion with @ddobrigk can we close this PR and proceed with a new and different PR?
Thanks.

@MaximVirta
Copy link
Contributor Author

MaximVirta commented Aug 7, 2024

Dear @MaximVirta, after the discussion with @ddobrigk can we close this PR and proceed with a new and different PR? Thanks.

Yes that should be done. My apologies to everyone who got notified from this PR as it was unnecessary.

@strogolo strogolo closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera requested changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@chiarapinto chiarapinto Awaiting requested review from chiarapinto

@BongHwi BongHwi Awaiting requested review from BongHwi

@mbombara mbombara Awaiting requested review from mbombara

@ChiaraDeMartin95 ChiaraDeMartin95 Awaiting requested review from ChiaraDeMartin95

@njacazio njacazio Awaiting requested review from njacazio

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@m-c-danisch m-c-danisch Awaiting requested review from m-c-danisch m-c-danisch is a code owner

@novitzky novitzky Awaiting requested review from novitzky novitzky is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

@ivorobye ivorobye Awaiting requested review from ivorobye ivorobye is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaximVirta @alibuild @strogolo @vkucera