-
Notifications
You must be signed in to change notification settings - Fork 14
Fix min/max value in Iceberg writes #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix min/max value in Iceberg writes #1192
Conversation
Enmk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I assume |
@zvonand Yes, it is unrelated. |
…eg_write_minmax Fix min/max value in Iceberg writes
|
Verification test: iceberg writes minmax This test reproduces a bug where ClickHouse incorrectly displays data when selecting after an insert. The test creates a partitioned Iceberg table, inserts data using INSERT INTO, and verifies the data can be read back correctly. This is a sanity check that min/max bounds are calculated correctly during writes, enabling proper min/max pruning for subsequent queries. Verification: |
|
In upstream is not reproduced from version 25.9+ |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix min/max value in Iceberg writes
Documentation entry for user-facing changes
During writing in Iceberg table ClickHouse incorrectly counts minimal and maximal values for columns.
As result min/max puning works incorrectly, cost column optimization (setting
allow_experimental_iceberg_read_optimization) also makes incorrect columns.Reproduced in upstream 25.8 LTS (25.8.12.129).
In 25.9 code was refactored, in new variant min/max counted correctly.
CI/CD Options
Exclude tests:
Regression jobs to run: