Skip to content

Conversation

@ianton-ru
Copy link

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix min/max value in Iceberg writes

Documentation entry for user-facing changes

During writing in Iceberg table ClickHouse incorrectly counts minimal and maximal values for columns.
As result min/max puning works incorrectly, cost column optimization (setting allow_experimental_iceberg_read_optimization) also makes incorrect columns.

Reproduced in upstream 25.8 LTS (25.8.12.129).

In 25.9 code was refactored, in new variant min/max counted correctly.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Workflow [PR], commit [ad27259]

Copy link
Member

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zvonand
Copy link
Collaborator

zvonand commented Dec 8, 2025

I assume 03644_object_storage_correlated_subqueries fails are not related?

@ianton-ru
Copy link
Author

ianton-ru commented Dec 8, 2025

I assume 03644_object_storage_correlated_subqueries fails are not related?

@zvonand Yes, it is unrelated.
Looks like allow_experimental_correlated_subqueries feature was backported in 25.8
f796fe7
before (without) test fix
ClickHouse@0e2c5b0
(ORDER BY required)

@zvonand zvonand merged commit 5fef745 into antalya-25.8 Dec 8, 2025
136 of 139 checks passed
zvonand added a commit that referenced this pull request Dec 9, 2025
…eg_write_minmax

Fix min/max value in Iceberg writes
@DimensionWieldr
Copy link
Collaborator

DimensionWieldr commented Dec 15, 2025

Verification test: iceberg writes minmax

This test reproduces a bug where ClickHouse incorrectly displays data when selecting after an insert.

The test creates a partitioned Iceberg table, inserts data using INSERT INTO, and verifies the data can be read back correctly. This is a sanity check that min/max bounds are calculated correctly during writes, enabling proper min/max pruning for subsequent queries.

Verification:

On 25.8.9.20496.altinityantalya, all checks failed
With PR build, all checks passed

@DimensionWieldr DimensionWieldr added the verified Verified by QA label Dec 15, 2025
@ianton-ru
Copy link
Author

ClickHouse#91589

@ianton-ru ianton-ru added the antalya-obsolete PR exists in higher Altinity release (doesn’t need forward porting) label Jan 12, 2026
@ianton-ru
Copy link
Author

ianton-ru commented Jan 12, 2026

In upstream is not reproduced from version 25.9+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

antalya antalya-25.8 antalya-obsolete PR exists in higher Altinity release (doesn’t need forward porting) verified Verified by QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants