Skip to content

Fix min/max value in Iceberg writes #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zvonand merged 2 commits into from
Dec 8, 2025
Merged

Fix min/max value in Iceberg writes #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf1872f
Fix min/max value in Iceberg writes
ianton-ru Dec 5, 2025
ad27259
Merge branch 'antalya-25.8' into bugfix/antalya-25.8/fix_icebereg_wri…
Enmk Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergWrites.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,11 +1232,6 @@ void IcebergStorageSink::consume(Chunk & chunk)
{
auto [data_filename, data_filename_in_storage] = filename_generator.generateDataFileName();
data_filenames[partition_key] = data_filename;
if (!statistics.contains(partition_key))
{
statistics.emplace(partition_key, current_schema->getArray(Iceberg::f_fields));
}
statistics.at(partition_key).update(part_chunk);

auto buffer = object_storage->writeObject(
StoredObject(data_filename_in_storage), WriteMode::Rewrite, std::nullopt, DBMS_DEFAULT_BUFFER_SIZE, context->getWriteSettings());
Expand All @@ -1252,6 +1247,12 @@ void IcebergStorageSink::consume(Chunk & chunk)
configuration->getFormat(), *write_buffers[partition_key], *sample_block, context, format_settings);
}

if (!statistics.contains(partition_key))
{
statistics.emplace(partition_key, current_schema->getArray(Iceberg::f_fields));
}
statistics.at(partition_key).update(part_chunk);

writers[partition_key]->write(getHeader().cloneWithColumns(part_chunk.getColumns()));
}
}
Expand Down
17 changes: 17 additions & 0 deletions tests/integration/test_storage_iceberg/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3850,6 +3850,7 @@ def test_system_tables_partition_sorting_keys(started_cluster, storage_type):
assert res == '"bucket(16, id), day(ts)","id desc, hour(ts) asc"'



@pytest.mark.parametrize(
"storage_type",
["s3", "azure", "local"],
Expand Down Expand Up @@ -3916,3 +3917,19 @@ def check_validity_and_get_prunned_files(select_expression):
)
== 3
)



def test_iceberg_write_minmax(started_cluster):
instance = started_cluster.instances["node1"]
TABLE_NAME = "test_iceberg_write_minmax_" + get_uuid_str()

create_iceberg_table("local", instance, TABLE_NAME, started_cluster, "(x Int32, y Int32)", partition_by="identity(x)")

instance.query(f"INSERT INTO {TABLE_NAME} VALUES (1, 1), (1, 2)", settings={"allow_experimental_insert_into_iceberg": 1})

res = instance.query(f"SELECT x,y FROM {TABLE_NAME} WHERE y=1 ORDER BY ALL").strip()
assert res == "1\t1"

res = instance.query(f"SELECT x,y FROM {TABLE_NAME} WHERE y=2 ORDER BY ALL").strip()
assert res == "1\t2"
Loading