Skip to content

Serialize DocumentReadyState#87

Merged
FlorianRappl merged 4 commits intoAngleSharp:develfrom
Sebbs128:readystate-serialize
Feb 29, 2024
Merged

Serialize DocumentReadyState#87
FlorianRappl merged 4 commits intoAngleSharp:develfrom
Sebbs128:readystate-serialize

Conversation

@Sebbs128
Copy link
Contributor

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

Serializes the DocumentReadyState enum for document.readyState based on the DomNameAttribute.OfficialName value if available.
Serializing other enum types has been left open, as too many tests/intended functionality breaks otherwise.

The serialized values are only available when AngleSharp v1.0.2 or greater is installed, otherwise previous behaviour is preserved.

Addresses #86

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2023

CLA assistant check
All committers have signed the CLA.

@FlorianRappl FlorianRappl mentioned this pull request Feb 28, 2024
9 tasks
Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FlorianRappl FlorianRappl merged commit 1a9cd80 into AngleSharp:devel Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants