Skip to content

Updated target frameworks#91

Merged
FlorianRappl merged 1 commit intoAngleSharp:develfrom
tomvanenckevort:update-target-frameworks
Mar 1, 2024
Merged

Updated target frameworks#91
FlorianRappl merged 1 commit intoAngleSharp:develfrom
tomvanenckevort:update-target-frameworks

Conversation

@tomvanenckevort
Copy link
Copy Markdown
Contributor

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

Updated the target frameworks for the project to be in line with AngleSharp (as discussed in #89).

Copy link
Copy Markdown
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

@FlorianRappl
Copy link
Copy Markdown
Contributor

The build is currently failing:

The current .NET SDK does not support targeting .NET 7.0. Either target .NET 6.0 or lower, or use a version of the .NET SDK that supports .NET 7.0. [/home/runner/work/AngleSharp.Js/AngleSharp.Js/src/AngleSharp.Js.Tests/AngleSharp.Js.Tests.csproj]

I think what needs to change is the installation of the frameworks. I've made the change in the devel branch.

@FlorianRappl FlorianRappl merged commit 0e8d85e into AngleSharp:devel Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants