Skip to content

Conversation

@liberodark
Copy link
Contributor

No description provided.

@probonopd
Copy link
Member

probonopd commented Jan 4, 2018

Thank you @liberodark. However there is no AppImage available for download on https://github.com/liberodark/ODrive/releases, hence the check fails. Please provide an AppImage for download, then comment here. Thanks.

@liberodark
Copy link
Contributor Author

Have Add AppImage

@probonopd
Copy link
Member

Thanks, I have triggered the test to run again.

@liberodark
Copy link
Contributor Author

liberodark commented Jan 5, 2018

thanks 👍

@liberodark
Copy link
Contributor Author

for what is not added ?

@probonopd
Copy link
Member

So the test is giving a green checkmark but the files are not extracted and added. This is most likely a bug in worker.sh. Needs to be debugged. I don't know what is going wrong.

@liberodark
Copy link
Contributor Author

our app works so it's a shame to see that it's still not in your hub despite our efforts to make an AppImage

@probonopd
Copy link
Member

Yes, I assume that it's most likely a bug in AppImageHub. Please understand that this is an open source project driven entirely by volunteers, so we need to find someone who has some time to debug the worker.sh bash script.

@simoniz0r
Copy link
Contributor

simoniz0r commented Feb 24, 2018

I would think you'd fix that before you start adding a whole bunch more AppImages... The whole excuse of "open source volunteer project" is pretty lame. Stop letting stuff like this just go with lame excuses like that. Fix it before it gets out of hand.

@simoniz0r
Copy link
Contributor

Also, expecting someone else to read through worker.sh, figure out what the scope of the script is, figure out where you've made errors, and fix them is a little much to expect especially when you don't have how worker.sh functions documented anywhere on AppImageHub.

If I were to try and fix it, I'd probably just end up doing a whole rewrite, but I'd have no clue where to start without taking like a week to figure out how it interacts with everything. You're the one who made these scripts and is familiar with them; you should be the one fixing them or at the very least explaining how they work well so that others have some idea where to start.

@probonopd
Copy link
Member

@simoniz0r please realize that this is a volunteer project, so everyone is just as welcome to improve things as is everyone else.

@simoniz0r
Copy link
Contributor

simoniz0r commented Feb 24, 2018

The vast majority of projects on Github are volunteer projects, yet you don't see them making excuses like that. Take the time to fix your own problems instead of expecting everyone else to jump in and do it for you.

Open Source is not about making something half broken and then expecting everyone else to fix it for you. It's about sharing your work with everyone so they can use it without having to reinvent the wheel. Sometimes you're lucky enough to get people to help fix your problems, but expecting that to happen every time you create something that's broken is just plain silly.

@probonopd
Copy link
Member

Well, first step is to open an issue, isn't it? ;-) #406

@probonopd probonopd mentioned this pull request Mar 13, 2018
@probonopd
Copy link
Member

probonopd commented Mar 18, 2018

@simoniz0r at least we know now that the files get generated but for some reason git refuses to "upload" them to this PR. While it does this for other PRs, e.g., this one I just made:

"Add automatically parsed data" is what doesn't seem to get appended to this PR, instead git is talking about a "detached HEAD" (what is this? sounds dramatic!) and I don't know why:

+git commit -F-
[detached HEAD bff19e7] Add automatically parsed data (2358) [ci skip]
 4 files changed, 119 insertions(+)
 create mode 100644 apps/odrive.md
 create mode 100644 database/odrive/odrive.desktop
 create mode 100644 database/odrive/package.json
 create mode 100644 database/odrive/screenshot.png
+set +x
+git push --set-upstream deploy
fatal: You are not currently on a branch.
To push the history leading to the current (detached HEAD)
state now, use
    git push deploy HEAD:<name-of-remote-branch>

This was referenced Mar 31, 2018
@probonopd probonopd merged commit d3612b5 into AppImage:master Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants